House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -12,22 +12,16 @@ namespace PrivaPub.Api.Mastodon.Controllers
|
||||
{
|
||||
// Mastodon's announcements: the administrators' (Domain/Social/Announcements.cs), each persona's dismissals and
|
||||
// reactions its own. Anonymous readers get the list without `read` or `me`.
|
||||
public class AnnouncementsController : MastodonController
|
||||
public class AnnouncementsController(
|
||||
IAnnouncements announcementService) : MastodonController
|
||||
{
|
||||
readonly IAnnouncements _announcements;
|
||||
|
||||
public AnnouncementsController(IAnnouncements announcements)
|
||||
{
|
||||
_announcements = announcements;
|
||||
}
|
||||
|
||||
[HttpGet("/api/v1/announcements"), Scope("read", requiresUser: false), AllowAnonymous]
|
||||
public async Task<IActionResult> List(CancellationToken token) =>
|
||||
Json(await Map(await _announcements.Shown(token), MyId, token));
|
||||
Json(await Map(await announcementService.Shown(token), MyId, token));
|
||||
|
||||
[HttpPost("/api/v1/announcements/{id}/dismiss"), Scope("write:accounts")]
|
||||
public async Task<IActionResult> Dismiss(string id, CancellationToken token) =>
|
||||
await _announcements.Dismiss(id, MyId, token) ? Json(new { }) : NotFoundError();
|
||||
await announcementService.Dismiss(id, MyId, token) ? Json(new { }) : NotFoundError();
|
||||
|
||||
[HttpPut("/api/v1/announcements/{id}/reactions/{name}"), Scope("write:favourites")]
|
||||
public Task<IActionResult> React(string id, string name, CancellationToken token) => Reaction(id, name, add: true, token);
|
||||
@@ -37,7 +31,7 @@ namespace PrivaPub.Api.Mastodon.Controllers
|
||||
|
||||
async Task<IActionResult> Reaction(string id, string name, bool add, CancellationToken token)
|
||||
{
|
||||
var (status, error) = await _announcements.React(id, MyId, name, add, token);
|
||||
var (status, error) = await announcementService.React(id, MyId, name, add, token);
|
||||
return error == default ? Json(new { }) : Error(status, error);
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user