House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -12,19 +12,13 @@ namespace PrivaPub.Api.Mastodon.Controllers
|
||||
{
|
||||
// Mastodon's lists (owner decision 2026-10-04, back from the cut list): a persona groups accounts it follows, reads them
|
||||
// as a timeline, and may keep an exclusive list's members out of its home. Nothing here leaves the server.
|
||||
public class ListsController : MastodonController
|
||||
public class ListsController(
|
||||
DbEntities dbEntities,
|
||||
MastodonMapper mapper) : MastodonController
|
||||
{
|
||||
const int MaxLists = 50;
|
||||
const int MaxMembers = 500;
|
||||
|
||||
readonly DbEntities _dbEntities;
|
||||
readonly MastodonMapper _mapper;
|
||||
|
||||
public ListsController(DbEntities dbEntities, MastodonMapper mapper)
|
||||
{
|
||||
_dbEntities = dbEntities;
|
||||
_mapper = mapper;
|
||||
}
|
||||
|
||||
static object View(PersonaList list) => new { id = list.ID, title = list.Title, replies_policy = list.RepliesPolicy, exclusive = list.Exclusive };
|
||||
|
||||
@@ -38,7 +32,7 @@ namespace PrivaPub.Api.Mastodon.Controllers
|
||||
var members = (await DB.Default.Find<PersonaListMember>().Match(m => m.ListId == list.ID).ExecuteAsync(token)).Select(m => m.AccountId).ToList();
|
||||
if (members.Count == 0)
|
||||
return members;
|
||||
var followed = (await _dbEntities.Followings.Match(f => f.AvatarId == MyId && f.State == FollowState.Accepted && members.Contains(f.TargetAccountId))
|
||||
var followed = (await dbEntities.Followings.Match(f => f.AvatarId == MyId && f.State == FollowState.Accepted && members.Contains(f.TargetAccountId))
|
||||
.ExecuteAsync(token)).Select(f => f.TargetAccountId).ToHashSet();
|
||||
var gone = members.Where(m => !followed.Contains(m)).ToList();
|
||||
if (gone.Count > 0)
|
||||
@@ -113,7 +107,7 @@ namespace PrivaPub.Api.Mastodon.Controllers
|
||||
return NotFoundError();
|
||||
await Members(list, token);
|
||||
var members = await Page.From(Params, Limit(40, 80)).Fetch(DB.Default.Find<PersonaListMember>().Match(m => m.ListId == list.ID), m => m.ID, token);
|
||||
var accounts = await _mapper.Accounts(members.Select(m => m.AccountId), token);
|
||||
var accounts = await mapper.Accounts(members.Select(m => m.AccountId), token);
|
||||
Link($"/api/v1/lists/{id}/accounts", members.LastOrDefault()?.ID, members.FirstOrDefault()?.ID);
|
||||
return Json(members.Where(m => accounts.ContainsKey(m.AccountId)).Select(m => accounts[m.AccountId]).ToList());
|
||||
}
|
||||
@@ -127,7 +121,7 @@ namespace PrivaPub.Api.Mastodon.Controllers
|
||||
var ids = Params.List("account_ids").Distinct().ToList();
|
||||
if (ids.Count == 0)
|
||||
return Error(StatusCodes.Status422UnprocessableEntity, "Validation failed: Account ids can't be blank");
|
||||
var followed = (await _dbEntities.Followings.Match(f => f.AvatarId == MyId && f.State == FollowState.Accepted && ids.Contains(f.TargetAccountId))
|
||||
var followed = (await dbEntities.Followings.Match(f => f.AvatarId == MyId && f.State == FollowState.Accepted && ids.Contains(f.TargetAccountId))
|
||||
.ExecuteAsync(token)).Select(f => f.TargetAccountId).ToHashSet();
|
||||
if (ids.Any(a => !followed.Contains(a)))
|
||||
return Error(StatusCodes.Status422UnprocessableEntity, "Validation failed: You must follow this account to add it to a list");
|
||||
@@ -168,12 +162,12 @@ namespace PrivaPub.Api.Mastodon.Controllers
|
||||
return NotFoundError();
|
||||
var members = await Members(list, token);
|
||||
var entries = await Page.From(Params, Limit()).Fetch(
|
||||
_dbEntities.TimelineEntries.Match(e => e.AvatarId == MyId && members.Contains(e.AuthorAccountId)), e => e.PostId, token);
|
||||
dbEntities.TimelineEntries.Match(e => e.AvatarId == MyId && members.Contains(e.AuthorAccountId)), e => e.PostId, token);
|
||||
var ids = entries.Select(e => e.PostId).ToList();
|
||||
var posts = (await _dbEntities.Posts.Match(p => ids.Contains(p.ID)).Match(VisibilityPolicy.IsShown).ExecuteAsync(token)).ToDictionary(p => p.ID);
|
||||
var posts = (await dbEntities.Posts.Match(p => ids.Contains(p.ID)).Match(VisibilityPolicy.IsShown).ExecuteAsync(token)).ToDictionary(p => p.ID);
|
||||
var answered = list.RepliesPolicy switch
|
||||
{
|
||||
ListRepliesPolicy.Followed => (await _dbEntities.Followings.Match(f => f.AvatarId == MyId && f.State == FollowState.Accepted).ExecuteAsync(token))
|
||||
ListRepliesPolicy.Followed => (await dbEntities.Followings.Match(f => f.AvatarId == MyId && f.State == FollowState.Accepted).ExecuteAsync(token))
|
||||
.Select(f => f.TargetAccountId).Append(MyId).ToHashSet(),
|
||||
ListRepliesPolicy.List => members.Append(MyId).ToHashSet(),
|
||||
_ => new HashSet<string> { MyId }
|
||||
@@ -183,7 +177,7 @@ namespace PrivaPub.Api.Mastodon.Controllers
|
||||
|| p.InReplyToAccountId != default && (p.InReplyToAccountId == p.AuthorAccountId || answered.Contains(p.InReplyToAccountId)))
|
||||
.ToList();
|
||||
Link($"/api/v1/timelines/list/{id}", entries.LastOrDefault()?.PostId, entries.FirstOrDefault()?.PostId);
|
||||
return Json(await _mapper.Statuses(shown, MyId, token));
|
||||
return Json(await mapper.Statuses(shown, MyId, token));
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user