House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -13,17 +13,10 @@ namespace PrivaPub.Api.Mastodon.Controllers
|
||||
{
|
||||
// Mastodon's scheduled statuses (owner decision 2026-10-04, back from the cut list): the persona's posts waiting for
|
||||
// their time, moved to another time or dropped. POST /api/v1/statuses with scheduled_at makes them.
|
||||
public class ScheduledStatusesController : MastodonController
|
||||
public class ScheduledStatusesController(
|
||||
IMediaService mediaService,
|
||||
IJobQueue jobs) : MastodonController
|
||||
{
|
||||
readonly IMediaService _media;
|
||||
readonly IJobQueue _jobs;
|
||||
|
||||
public ScheduledStatusesController(IMediaService media, IJobQueue jobs)
|
||||
{
|
||||
_media = media;
|
||||
_jobs = jobs;
|
||||
}
|
||||
|
||||
public static async Task<object> View(ScheduledStatus scheduled, IMediaService media, CancellationToken token)
|
||||
{
|
||||
var p = scheduled.Params;
|
||||
@@ -66,13 +59,13 @@ namespace PrivaPub.Api.Mastodon.Controllers
|
||||
Link("/api/v1/scheduled_statuses", page.LastOrDefault()?.ID, page.FirstOrDefault()?.ID);
|
||||
var views = new List<object>();
|
||||
foreach (var scheduled in page)
|
||||
views.Add(await View(scheduled, _media, token));
|
||||
views.Add(await View(scheduled, mediaService, token));
|
||||
return Json(views);
|
||||
}
|
||||
|
||||
[HttpGet("/api/v1/scheduled_statuses/{id}"), Scope("read:statuses")]
|
||||
public async Task<IActionResult> One(string id, CancellationToken token) =>
|
||||
await Mine(id, token) is { } scheduled ? Json(await View(scheduled, _media, token)) : NotFoundError();
|
||||
await Mine(id, token) is { } scheduled ? Json(await View(scheduled, mediaService, token)) : NotFoundError();
|
||||
|
||||
[HttpPut("/api/v1/scheduled_statuses/{id}"), Scope("write:statuses")]
|
||||
public async Task<IActionResult> Move(string id, CancellationToken token)
|
||||
@@ -86,8 +79,8 @@ namespace PrivaPub.Api.Mastodon.Controllers
|
||||
return Error(StatusCodes.Status422UnprocessableEntity, "Validation failed: " + refusal);
|
||||
scheduled.ScheduledAt = at;
|
||||
await DB.Default.Update<ScheduledStatus>().MatchID(scheduled.ID).Modify(s => s.ScheduledAt, at).ExecuteAsync(token);
|
||||
await _jobs.EnqueueMany(new[] { ScheduledStatuses.JobFor(scheduled, new Uri(Me.BaseAddress).Host) }, token);
|
||||
return Json(await View(scheduled, _media, token));
|
||||
await jobs.EnqueueMany(new[] { ScheduledStatuses.JobFor(scheduled, new Uri(Me.BaseAddress).Host) }, token);
|
||||
return Json(await View(scheduled, mediaService, token));
|
||||
}
|
||||
|
||||
[HttpDelete("/api/v1/scheduled_statuses/{id}"), Scope("write:statuses")]
|
||||
@@ -97,7 +90,7 @@ namespace PrivaPub.Api.Mastodon.Controllers
|
||||
return NotFoundError();
|
||||
await DB.Default.DeleteAsync<ScheduledStatus>(scheduled.ID);
|
||||
// its media were the scheduled post's alone, never posted
|
||||
await _media.Trash(m => m.ScheduledStatusId == scheduled.ID, "scheduled post dropped", token);
|
||||
await mediaService.Trash(m => m.ScheduledStatusId == scheduled.ID, "scheduled post dropped", token);
|
||||
return Json(new { });
|
||||
}
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user