House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -15,17 +15,10 @@ namespace PrivaPub.Api.Mastodon.Controllers
|
||||
{
|
||||
// Follow suggestions as Mastodon's API has them (completion program R8; who and why in Domain/Social/Suggestions): v1 the
|
||||
// accounts, v2 each with its reasons; a dismissed account is never suggested to that persona again.
|
||||
public class SuggestionsController : MastodonController
|
||||
public class SuggestionsController(
|
||||
MastodonMapper mapper,
|
||||
IInstanceSettings settings) : MastodonController
|
||||
{
|
||||
readonly MastodonMapper _mapper;
|
||||
readonly IInstanceSettings _settings;
|
||||
|
||||
public SuggestionsController(MastodonMapper mapper, IInstanceSettings settings)
|
||||
{
|
||||
_mapper = mapper;
|
||||
_settings = settings;
|
||||
}
|
||||
|
||||
[HttpGet("/api/v1/suggestions"), Scope("read")]
|
||||
public async Task<IActionResult> V1(CancellationToken token) => Json((await Suggested(token)).Select(s => s.Account).ToList());
|
||||
|
||||
@@ -53,12 +46,12 @@ namespace PrivaPub.Api.Mastodon.Controllers
|
||||
async Task<List<Suggestion>> Suggested(CancellationToken token)
|
||||
{
|
||||
var limit = Limit(40, 80);
|
||||
var candidates = await Suggestions.For(Me, _settings.Current.StaffPicks, token);
|
||||
var candidates = await Suggestions.For(Me, settings.Current.StaffPicks, token);
|
||||
var suggested = new List<Suggestion>();
|
||||
for (var start = 0; start < candidates.Count && suggested.Count < limit; start += limit * 2)
|
||||
{
|
||||
var chunk = candidates.Skip(start).Take(limit * 2).ToList();
|
||||
var accounts = await _mapper.Accounts(chunk.Select(c => c.AccountId), token);
|
||||
var accounts = await mapper.Accounts(chunk.Select(c => c.AccountId), token);
|
||||
var hidden = await Hidden.AuthorsHiddenFrom(MyId, accounts.Values.Select(a => a.Uri), forNotifications: false, token);
|
||||
foreach (var candidate in chunk)
|
||||
{
|
||||
|
||||
Reference in new issue
Block a user