House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -9,26 +9,20 @@ namespace PrivaPub.Api.Mastodon.Controllers
|
||||
// Mastodon 4.4's OAuth userinfo (OpenID Connect's shape, GET or POST, the `profile` scope): who the token's persona is,
|
||||
// for a site that signs in with it. Only what its public account says already; never its login. The authorization
|
||||
// server's metadata names it (OAuthSetup).
|
||||
public class UserinfoController : MastodonController
|
||||
public class UserinfoController(
|
||||
MastodonMapper mapper,
|
||||
ILocalActorService localActors) : MastodonController
|
||||
{
|
||||
public const string Path = "/oauth/userinfo";
|
||||
|
||||
readonly MastodonMapper _mapper;
|
||||
readonly ILocalActorService _localActors;
|
||||
|
||||
public UserinfoController(MastodonMapper mapper, ILocalActorService localActors)
|
||||
{
|
||||
_mapper = mapper;
|
||||
_localActors = localActors;
|
||||
}
|
||||
|
||||
[HttpGet(Path), HttpPost(Path), Scope("profile")]
|
||||
public async Task<IActionResult> Show(CancellationToken token)
|
||||
{
|
||||
var account = await _mapper.Local(Me, false, token);
|
||||
var account = await mapper.Local(Me, false, token);
|
||||
return Json(new
|
||||
{
|
||||
iss = _localActors.BaseAddress + "/",
|
||||
iss = localActors.BaseAddress + "/",
|
||||
sub = Me.Uri,
|
||||
name = account.DisplayName,
|
||||
preferred_username = account.Username,
|
||||
|
||||
Reference in new issue
Block a user