House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -9,24 +9,16 @@ namespace PrivaPub.Controllers.ClientToServer
|
||||
{
|
||||
[ApiController,
|
||||
Route("clientapi/data")]
|
||||
public class DataController : ControllerBase
|
||||
public class DataController(
|
||||
IDataService dataService,
|
||||
ILogger<DataController> logger) : ControllerBase
|
||||
{
|
||||
readonly IDataService DataService;
|
||||
readonly ILogger<DataController> Logger;
|
||||
|
||||
public DataController(IDataService dataService,
|
||||
ILogger<DataController> logger)
|
||||
{
|
||||
DataService = dataService;
|
||||
Logger = logger;
|
||||
}
|
||||
|
||||
[HttpGet, Route("/clientapi/data/ping"), AllowAnonymous]
|
||||
public async ValueTask<IActionResult> Ping() => NoContent();
|
||||
public async ValueTask<IActionResult> Ping(CancellationToken token = default) => NoContent();
|
||||
|
||||
[HttpGet, Route("/clientapi/data/current-version"), AllowAnonymous]
|
||||
public IActionResult CurrentVersion() =>
|
||||
Ok(DataService.GetCurrentVersion());
|
||||
Ok(dataService.GetCurrentVersion());
|
||||
|
||||
[HttpGet, Route("/clientapi/data/languages"), AllowAnonymous]
|
||||
public async Task<IActionResult> Languages(CancellationToken cancellationToken)
|
||||
@@ -34,7 +26,7 @@ namespace PrivaPub.Controllers.ClientToServer
|
||||
var result = new WebResult();
|
||||
try
|
||||
{
|
||||
var languages = await DataService.GetLanguages(cancellationToken);
|
||||
var languages = await dataService.GetLanguages(cancellationToken);
|
||||
var viewLanguages = new List<ViewLanguage>();
|
||||
|
||||
viewLanguages.AddRange(languages.Select(l => new ViewLanguage
|
||||
@@ -47,7 +39,7 @@ namespace PrivaPub.Controllers.ClientToServer
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
Logger.LogError(ex, $"{nameof(DataController)}.{nameof(Languages)}()");
|
||||
logger.LogError(ex, $"{nameof(DataController)}.{nameof(Languages)}()");
|
||||
return BadRequest(result.Invalidate("Something went wrong.", exception: ex));
|
||||
}
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user