House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -14,27 +14,19 @@ namespace PrivaPub.Controllers.ClientToServer
|
||||
[ApiController,
|
||||
Route("clientapi/admin/statistics"),
|
||||
Authorize(Policy = Policies.IsAdmin)]
|
||||
public class StatisticsController : ControllerBase
|
||||
public class StatisticsController(
|
||||
StatisticsQueries queries,
|
||||
IJobQueue queue,
|
||||
Microsoft.Extensions.Options.IOptionsMonitor<StatisticsOptions> options) : ControllerBase
|
||||
{
|
||||
readonly StatisticsQueries _queries;
|
||||
readonly IJobQueue _queue;
|
||||
readonly Microsoft.Extensions.Options.IOptionsMonitor<StatisticsOptions> _options;
|
||||
|
||||
public StatisticsController(StatisticsQueries queries, IJobQueue queue, Microsoft.Extensions.Options.IOptionsMonitor<StatisticsOptions> options)
|
||||
{
|
||||
_queries = queries;
|
||||
_queue = queue;
|
||||
_options = options;
|
||||
}
|
||||
|
||||
[HttpGet, Route("/clientapi/admin/statistics/crawler")]
|
||||
public async Task<IActionResult> Crawler(CancellationToken token) =>
|
||||
Ok(await _queries.Crawler(_options.CurrentValue.Crawler.Enabled, _options.CurrentValue.Crawler.RevisitDays, token));
|
||||
Ok(await queries.Crawler(options.CurrentValue.Crawler.Enabled, options.CurrentValue.Crawler.RevisitDays, token));
|
||||
|
||||
[HttpGet, Route("/clientapi/admin/statistics/overview")]
|
||||
public async Task<IActionResult> Overview([FromServices] Domain.Media.IMediaService media, [FromQuery] int days = 30, CancellationToken token = default)
|
||||
{
|
||||
var overview = await _queries.Overview(days, token);
|
||||
var overview = await queries.Overview(days, token);
|
||||
overview.Media.ProxyCacheBytes = Bytes(media.ProxyRoot);
|
||||
overview.Media.TrashBytes = Bytes(media.TrashRoot);
|
||||
return Ok(overview);
|
||||
@@ -46,20 +38,20 @@ namespace PrivaPub.Controllers.ClientToServer
|
||||
[HttpGet, Route("/clientapi/admin/statistics/hosts")]
|
||||
public async Task<IActionResult> Hosts([FromQuery] int days = 30, [FromQuery] string sort = default, [FromQuery] string software = default,
|
||||
[FromQuery] int page = 1, [FromQuery] int limit = 50, CancellationToken token = default) =>
|
||||
Ok(await _queries.Hosts(days, sort, software, page, limit, token));
|
||||
Ok(await queries.Hosts(days, sort, software, page, limit, token));
|
||||
|
||||
[HttpGet, Route("/clientapi/admin/statistics/hosts/{host}")]
|
||||
public async Task<IActionResult> Host(string host, [FromQuery] int days = 90, CancellationToken token = default) =>
|
||||
await _queries.Host(host, days, token) is { } found ? Ok(found) : NotFound();
|
||||
await queries.Host(host, days, token) is { } found ? Ok(found) : NotFound();
|
||||
|
||||
[HttpGet, Route("/clientapi/admin/statistics/events")]
|
||||
public async Task<IActionResult> Events([FromQuery] string host = default, [FromQuery] string channel = default, [FromQuery] string outcome = default,
|
||||
[FromQuery] string reason = default, [FromQuery] DateTime? before = default, [FromQuery] int limit = 100, CancellationToken token = default) =>
|
||||
Ok(await _queries.Events(host, channel, outcome, reason, before, limit, token));
|
||||
Ok(await queries.Events(host, channel, outcome, reason, before, limit, token));
|
||||
|
||||
[HttpGet, Route("/clientapi/admin/statistics/server")]
|
||||
public async Task<IActionResult> Server([FromQuery] int days = 30, CancellationToken token = default) =>
|
||||
Ok(await _queries.Server(days, token));
|
||||
Ok(await queries.Server(days, token));
|
||||
|
||||
[HttpPost, Route("/clientapi/admin/statistics/rollups/{day}")]
|
||||
public async Task<IActionResult> Rollup(string day, CancellationToken token)
|
||||
@@ -69,7 +61,7 @@ namespace PrivaPub.Controllers.ClientToServer
|
||||
return BadRequest();
|
||||
var job = RollupJob.For(parsed.Date, $"rollup|{day}|rerun|{DateTime.UtcNow.Ticks}");
|
||||
job.RunAt = DateTime.UtcNow;
|
||||
await _queue.EnqueueMany(new[] { job }, token);
|
||||
await queue.EnqueueMany(new[] { job }, token);
|
||||
return Accepted();
|
||||
}
|
||||
|
||||
@@ -79,7 +71,7 @@ namespace PrivaPub.Controllers.ClientToServer
|
||||
host = Interactions.Host(host);
|
||||
if (host == Interactions.Unknown)
|
||||
return BadRequest();
|
||||
await _queue.Enqueue(JobKind.DescribeInstance, host, host, $"describe|{host}|admin|{DateTime.UtcNow.Ticks}", token);
|
||||
await queue.Enqueue(JobKind.DescribeInstance, host, host, $"describe|{host}|admin|{DateTime.UtcNow.Ticks}", token);
|
||||
return Accepted();
|
||||
}
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user