House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -10,28 +10,22 @@ namespace PrivaPub.Controllers.ClientToServer
|
||||
[ApiController,
|
||||
Route("clientapi/timeline"),
|
||||
Authorize(Policy = Policies.IsUser)]
|
||||
public class TimelineController : ControllerBase
|
||||
public class TimelineController(
|
||||
ITimelineService timelines) : ControllerBase
|
||||
{
|
||||
readonly ITimelineService _timelines;
|
||||
|
||||
public TimelineController(ITimelineService timelines)
|
||||
{
|
||||
_timelines = timelines;
|
||||
}
|
||||
|
||||
[HttpGet, Route("/clientapi/timeline/home")]
|
||||
public async Task<IActionResult> Home([FromQuery] string avatarId, [FromQuery(Name = "max_id")] string maxId, [FromQuery] int limit = 20,
|
||||
CancellationToken token = default) =>
|
||||
Answer(await _timelines.Home(User.GetUserId(), avatarId, maxId, limit, token));
|
||||
Answer(await timelines.Home(User.GetUserId(), avatarId, maxId, limit, token));
|
||||
|
||||
[HttpGet, Route("/clientapi/notifications")]
|
||||
public async Task<IActionResult> Notifications([FromQuery] string avatarId, [FromQuery(Name = "max_id")] string maxId, [FromQuery] int limit = 20,
|
||||
CancellationToken token = default) =>
|
||||
Answer(await _timelines.Notifications(User.GetUserId(), avatarId, maxId, limit, token));
|
||||
Answer(await timelines.Notifications(User.GetUserId(), avatarId, maxId, limit, token));
|
||||
|
||||
[HttpPost, Route("/clientapi/notifications/read")]
|
||||
public async Task<IActionResult> Read([FromQuery] string avatarId, CancellationToken token) =>
|
||||
Answer(await _timelines.MarkNotificationsRead(User.GetUserId(), avatarId, token));
|
||||
Answer(await timelines.MarkNotificationsRead(User.GetUserId(), avatarId, token));
|
||||
|
||||
IActionResult Answer(WebResult result) => result.IsValid ? Ok(result.Data) : StatusCode(result.StatusCode, result);
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user