House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -25,19 +25,14 @@ namespace PrivaPub.Domain.Instance
|
||||
// The server's own settings (Models/ServerSettings.cs) in memory: read at start, saved from the administrator's page, and
|
||||
// read again every five minutes (InstanceSettingsRefresher), so an edit made elsewhere takes too. What reads them reads
|
||||
// Current, which is never null and never changed in place.
|
||||
public class InstanceSettings : IInstanceSettings
|
||||
public class InstanceSettings(
|
||||
ILogger<InstanceSettings> logger) : IInstanceSettings
|
||||
{
|
||||
readonly ILogger<InstanceSettings> _logger;
|
||||
readonly SemaphoreSlim _saving = new(1, 1);
|
||||
volatile ServerSettings _current = ServerSettings.Defaults();
|
||||
volatile bool _stored;//whether Current came from the document (or is the defaults)
|
||||
CancellationTokenSource _changed = new();
|
||||
|
||||
public InstanceSettings(ILogger<InstanceSettings> logger)
|
||||
{
|
||||
_logger = logger;
|
||||
}
|
||||
|
||||
public ServerSettings Current => _current;
|
||||
|
||||
public IChangeToken ChangeToken() => new CancellationChangeToken(Volatile.Read(ref _changed).Token);
|
||||
@@ -85,7 +80,7 @@ namespace PrivaPub.Domain.Instance
|
||||
}
|
||||
catch (AggregateException ex)
|
||||
{
|
||||
_logger.LogWarning(ex, "A listener to the server's settings failed");
|
||||
logger.LogWarning(ex, "A listener to the server's settings failed");
|
||||
}
|
||||
//(not disposed: a reader may still be registering on its token)
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user