House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -8,17 +8,10 @@ namespace PrivaPub.Domain.Media
|
||||
{
|
||||
// Audio and video sent to /api/v2/media, processed off the request (its lease renewed while ffmpeg runs): playable, or
|
||||
// marked failed with why. One at a time, since a transcode takes the machine's cores.
|
||||
public class ProcessMediaJob : IJobHandler
|
||||
public class ProcessMediaJob(
|
||||
IMediaService mediaService,
|
||||
ILogger<ProcessMediaJob> logger) : IJobHandler
|
||||
{
|
||||
readonly IMediaService _media;
|
||||
readonly ILogger<ProcessMediaJob> _logger;
|
||||
|
||||
public ProcessMediaJob(IMediaService media, ILogger<ProcessMediaJob> logger)
|
||||
{
|
||||
_media = media;
|
||||
_logger = logger;
|
||||
}
|
||||
|
||||
public JobKind Kind => JobKind.ProcessMedia;
|
||||
public int Concurrency => 1;
|
||||
public int MaxAttempts => 3;
|
||||
@@ -37,8 +30,8 @@ namespace PrivaPub.Domain.Media
|
||||
var pending = await DB.Default.Find<MediaAttachment>().Match(m => m.ID == job.Payload && m.ProcessingState == "pending" && m.TrashedAt == null).ExecuteFirstAsync(token);
|
||||
if (pending == default)
|
||||
return JobOutcome.Done;//processed already, or trashed meanwhile
|
||||
if (!await _media.ProcessPending(pending, token))
|
||||
_logger.LogInformation("Upload {Id} could not be processed", pending.ID);
|
||||
if (!await mediaService.ProcessPending(pending, token))
|
||||
logger.LogInformation("Upload {Id} could not be processed", pending.ID);
|
||||
return JobOutcome.Done;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user