House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -17,17 +17,12 @@ namespace PrivaPub.Domain.Moderation
|
||||
// (ModeratorController's /clientapi/moderator/log). An entry never holds an IP address, and never pairs a root with its
|
||||
// own personas: an act on a persona that the acting root owns, on a post of it, a group it owns or a report about it
|
||||
// (R6), is kept without who acted.
|
||||
public class ModerationLog : IModerationLog
|
||||
public class ModerationLog(
|
||||
ILogger<ModerationLog> logger) : IModerationLog
|
||||
{
|
||||
const int MaxLabel = 200;
|
||||
const int MaxNote = 1000;
|
||||
|
||||
readonly ILogger<ModerationLog> _logger;
|
||||
|
||||
public ModerationLog(ILogger<ModerationLog> logger)
|
||||
{
|
||||
_logger = logger;
|
||||
}
|
||||
|
||||
public async Task Write(string byRootId, string action, string targetKind, string targetId, string targetLabel, string reportId = default,
|
||||
string note = default, CancellationToken token = default)
|
||||
@@ -49,7 +44,7 @@ namespace PrivaPub.Domain.Moderation
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogWarning(ex, "The staff's log could not keep a {Action}", action);
|
||||
logger.LogWarning(ex, "The staff's log could not keep a {Action}", action);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user