House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -13,26 +13,20 @@ namespace PrivaPub.Domain.Social
|
||||
// and fetch nothing). Hashtags and links rise with the number of different authors using them today against the
|
||||
// week before; posts with their favourites, boosts and replies, halving every twelve hours. A post trends only if its
|
||||
// author is discoverable, and nothing warned about (content warning) trends. Computed at most every ten minutes.
|
||||
public sealed class Trends
|
||||
public sealed class Trends(
|
||||
DbEntities dbEntities,
|
||||
IMemoryCache cache)
|
||||
{
|
||||
public static readonly TimeSpan Fresh = TimeSpan.FromMinutes(10);
|
||||
const int MinAuthors = 2;//one account alone never makes a trend
|
||||
const int Kept = 40;
|
||||
|
||||
readonly DbEntities _dbEntities;
|
||||
readonly IMemoryCache _cache;
|
||||
|
||||
public Trends(DbEntities dbEntities, IMemoryCache cache)
|
||||
{
|
||||
_dbEntities = dbEntities;
|
||||
_cache = cache;
|
||||
}
|
||||
|
||||
// what is computed is forgotten: the next read computes it again
|
||||
public void Forget()
|
||||
{
|
||||
foreach (var key in new[] { "trends:tags", "trends:links", "trends:statuses" })
|
||||
_cache.Remove(key);
|
||||
cache.Remove(key);
|
||||
}
|
||||
|
||||
public sealed record DayUse(DateTime Day, int Uses, int Accounts);
|
||||
@@ -40,7 +34,7 @@ namespace PrivaPub.Domain.Social
|
||||
public sealed record Trend(string Key, List<DayUse> History, string SamplePostId);
|
||||
|
||||
public Task<List<Trend>> Tags(CancellationToken token) =>
|
||||
_cache.GetOrCreateAsync("trends:tags", async entry =>
|
||||
cache.GetOrCreateAsync("trends:tags", async entry =>
|
||||
{
|
||||
entry.AbsoluteExpirationRelativeToNow = Fresh;
|
||||
var posts = await Week(p => p.Tags.Count > 0, token);
|
||||
@@ -48,7 +42,7 @@ namespace PrivaPub.Domain.Social
|
||||
});
|
||||
|
||||
public Task<List<Trend>> Links(CancellationToken token) =>
|
||||
_cache.GetOrCreateAsync("trends:links", async entry =>
|
||||
cache.GetOrCreateAsync("trends:links", async entry =>
|
||||
{
|
||||
entry.AbsoluteExpirationRelativeToNow = Fresh;
|
||||
var posts = await Week(p => p.Link != null, token);
|
||||
@@ -58,12 +52,12 @@ namespace PrivaPub.Domain.Social
|
||||
|
||||
// the ids of the trending posts, best first
|
||||
public Task<List<string>> Statuses(CancellationToken token) =>
|
||||
_cache.GetOrCreateAsync("trends:statuses", async entry =>
|
||||
cache.GetOrCreateAsync("trends:statuses", async entry =>
|
||||
{
|
||||
entry.AbsoluteExpirationRelativeToNow = Fresh;
|
||||
var now = DateTime.UtcNow;
|
||||
var since = now.AddHours(-48);
|
||||
var posts = await _dbEntities.Posts
|
||||
var posts = await dbEntities.Posts
|
||||
.Match(p => p.Visibility == PostVisibility.Public && !p.DeletedAt.HasValue && !p.AuthorGone && !p.HasContentWarning && !p.IsLocalOnly
|
||||
&& p.ReblogOfPostId == null && p.InReplyToURI == null && p.AnsweringToPostId == null && p.CreationDate >= since
|
||||
&& p.FavouritesCount + p.ReblogsCount + p.RepliesCount > 0)
|
||||
@@ -78,7 +72,7 @@ namespace PrivaPub.Domain.Social
|
||||
Task<List<Post>> Week(System.Linq.Expressions.Expression<Func<Post, bool>> with, CancellationToken token)
|
||||
{
|
||||
var since = DateTime.UtcNow.Date.AddDays(-6);
|
||||
return _dbEntities.Posts
|
||||
return dbEntities.Posts
|
||||
.Match(p => p.Visibility == PostVisibility.Public && !p.DeletedAt.HasValue && !p.AuthorGone && !p.HasContentWarning && !p.IsLocalOnly
|
||||
&& p.ReblogOfPostId == null && p.CreationDate >= since)
|
||||
.Match(Privacy.VisibilityPolicy.IsPublic).Match(Privacy.VisibilityPolicy.IsListed)
|
||||
|
||||
Reference in new issue
Block a user