House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -14,20 +14,13 @@ namespace PrivaPub.Federation.Actors
|
||||
// The latest public posts of an account a persona has just followed, read from the first page of its outbox (at most
|
||||
// twenty, once a day) and kept as any fetched post: its profile shows them and threads find them at once, instead of
|
||||
// only what it posts from then on. Homes still get only what arrives from now on, as on Mastodon.
|
||||
public class OutboxBackfill : IJobHandler
|
||||
public class OutboxBackfill(
|
||||
DbEntities dbEntities,
|
||||
IRemoteActorService remoteActors,
|
||||
IRemotePosts remotePosts) : IJobHandler
|
||||
{
|
||||
public const int MaxPosts = 20;
|
||||
|
||||
readonly DbEntities _dbEntities;
|
||||
readonly IRemoteActorService _remoteActors;
|
||||
readonly IRemotePosts _remotePosts;
|
||||
|
||||
public OutboxBackfill(DbEntities dbEntities, IRemoteActorService remoteActors, IRemotePosts remotePosts)
|
||||
{
|
||||
_dbEntities = dbEntities;
|
||||
_remoteActors = remoteActors;
|
||||
_remotePosts = remotePosts;
|
||||
}
|
||||
|
||||
public JobKind Kind => JobKind.BackfillOutbox;
|
||||
public int Concurrency => 1;
|
||||
@@ -38,11 +31,11 @@ namespace PrivaPub.Federation.Actors
|
||||
|
||||
public async Task<JobOutcome> Handle(Job job, CancellationToken token)
|
||||
{
|
||||
var actor = await _dbEntities.ForeignAvatars.Match(a => a.ActorURI == job.Payload && !a.DeletionAt.HasValue).ExecuteFirstAsync(token);
|
||||
var actor = await dbEntities.ForeignAvatars.Match(a => a.ActorURI == job.Payload && !a.DeletionAt.HasValue).ExecuteFirstAsync(token);
|
||||
if (actor == default || string.IsNullOrEmpty(actor.OutboxURL) || !Origin.Same(actor.OutboxURL, actor.ActorURI))
|
||||
return JobOutcome.Done;
|
||||
foreach (var objectUri in (await Items(actor, token)).Take(MaxPosts))
|
||||
await _remotePosts.StoreContext(objectUri, 0, token);
|
||||
await remotePosts.StoreContext(objectUri, 0, token);
|
||||
return JobOutcome.Done;
|
||||
}
|
||||
|
||||
@@ -51,7 +44,7 @@ namespace PrivaPub.Federation.Actors
|
||||
async Task<List<string>> Items(Models.User.ForeignAvatar actor, CancellationToken token)
|
||||
{
|
||||
using var scope = HttpScope.For("outbox");
|
||||
using var outbox = await _remoteActors.FetchObject(actor.OutboxURL, token);
|
||||
using var outbox = await remoteActors.FetchObject(actor.OutboxURL, token);
|
||||
if (outbox == default || outbox.Root.ValueKind != JsonValueKind.Object)
|
||||
return new();
|
||||
var page = ItemsOf(outbox.Root, actor);
|
||||
@@ -62,7 +55,7 @@ namespace PrivaPub.Federation.Actors
|
||||
var pageUri = first.ValueKind == JsonValueKind.String ? first.GetString() : default;
|
||||
if (pageUri == default || !Origin.Same(pageUri, actor.ActorURI))
|
||||
return page;
|
||||
using var fetched = await _remoteActors.FetchObject(pageUri, token);
|
||||
using var fetched = await remoteActors.FetchObject(pageUri, token);
|
||||
return fetched == default || fetched.Root.ValueKind != JsonValueKind.Object ? page : ItemsOf(fetched.Root, actor);
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user