House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -17,16 +17,11 @@ namespace PrivaPub.Federation.Controllers
|
||||
// answers 410 with a Tombstone. An emoji tells nothing about anyone, so it is served unsigned under SecureMode too, as the
|
||||
// server's own actors are; a browser is sent to the picture.
|
||||
[ApiController]
|
||||
public class EmojisController : ControllerBase
|
||||
public class EmojisController(
|
||||
ILocalActorService localActors) : ControllerBase
|
||||
{
|
||||
const string ActivityContentType = "application/activity+json; charset=utf-8";
|
||||
|
||||
readonly ILocalActorService _localActors;
|
||||
|
||||
public EmojisController(ILocalActorService localActors)
|
||||
{
|
||||
_localActors = localActors;
|
||||
}
|
||||
|
||||
[HttpGet, Route("/" + LocalEmojis.Path + "/{shortcode}")]
|
||||
public async Task<IActionResult> Get(string shortcode, CancellationToken token)
|
||||
@@ -44,7 +39,7 @@ namespace PrivaPub.Federation.Controllers
|
||||
Content = new JsonObject
|
||||
{
|
||||
["@context"] = ActivityPubRenderer.ActivityStreams,
|
||||
["id"] = LocalEmojis.Uri(_localActors.BaseAddress, emoji.Shortcode),
|
||||
["id"] = LocalEmojis.Uri(localActors.BaseAddress, emoji.Shortcode),
|
||||
["type"] = "Tombstone",
|
||||
["formerType"] = "Emoji",
|
||||
["deleted"] = ActivityPubRenderer.Timestamp(deleted)
|
||||
@@ -60,7 +55,7 @@ namespace PrivaPub.Federation.Controllers
|
||||
emoji.ImageUpdatedAt, emoji.Category, emoji.VisibleInPicker);
|
||||
return new ContentResult
|
||||
{
|
||||
Content = LocalEmojis.Document(live, _localActors.BaseAddress).ToJsonString(),
|
||||
Content = LocalEmojis.Document(live, localActors.BaseAddress).ToJsonString(),
|
||||
ContentType = ActivityContentType,
|
||||
StatusCode = StatusCodes.Status200OK
|
||||
};
|
||||
|
||||
Reference in new issue
Block a user