House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -12,53 +12,40 @@ using static PrivaPub.Federation.Objects.ActivityJson;
|
||||
|
||||
namespace PrivaPub.Federation.Inbox.Handlers
|
||||
{
|
||||
public class AcceptHandler : IActivityHandler
|
||||
public class AcceptHandler(
|
||||
DbEntities db,
|
||||
ILocalActorService localActorService,
|
||||
IQuoteService quotes,
|
||||
IInteractionApprovals approvals = default,
|
||||
IParticipations participations = default,
|
||||
Relays.IRelays relays = default,
|
||||
Infrastructure.Jobs.IJobQueue queue = default) : IActivityHandler
|
||||
{
|
||||
readonly DbEntities _dbEntities;
|
||||
readonly ILocalActorService _localActors;
|
||||
readonly IQuoteService _quotes;
|
||||
readonly IInteractionApprovals _approvals;
|
||||
readonly IParticipations _participations;
|
||||
readonly Relays.IRelays _relays;
|
||||
readonly Infrastructure.Jobs.IJobQueue _queue;
|
||||
|
||||
public AcceptHandler(DbEntities dbEntities, ILocalActorService localActors, IQuoteService quotes, IInteractionApprovals approvals = default,
|
||||
IParticipations participations = default, Relays.IRelays relays = default, Infrastructure.Jobs.IJobQueue queue = default)
|
||||
{
|
||||
_queue = queue;
|
||||
_relays = relays;
|
||||
_participations = participations;
|
||||
_dbEntities = dbEntities;
|
||||
_localActors = localActors;
|
||||
_quotes = quotes;
|
||||
_approvals = approvals;
|
||||
}
|
||||
|
||||
public virtual string Type => "Accept";
|
||||
|
||||
public async Task Handle(JsonNode activity, ForeignAvatar actor, CancellationToken token)
|
||||
{
|
||||
if (await _quotes.Answered(activity, actor, accepted: Type == "Accept", token))
|
||||
if (await quotes.Answered(activity, actor, accepted: Type == "Accept", token))
|
||||
{
|
||||
Arrival.Accept("quote-answer");
|
||||
return;
|
||||
}
|
||||
if (_approvals != default && await _approvals.Answered(activity, actor, accepted: Type == "Accept", token))
|
||||
if (approvals != default && await approvals.Answered(activity, actor, accepted: Type == "Accept", token))
|
||||
{
|
||||
Arrival.Accept("interaction-answer");
|
||||
return;
|
||||
}
|
||||
if (_participations != default && await _participations.Answered(activity, actor, accepted: Type == "Accept", token))
|
||||
if (participations != default && await participations.Answered(activity, actor, accepted: Type == "Accept", token))
|
||||
{
|
||||
Arrival.Accept("participation-answer");
|
||||
return;
|
||||
}
|
||||
if (_relays != default && await _relays.Answered(activity, actor, accepted: Type == "Accept", token))
|
||||
if (relays != default && await relays.Answered(activity, actor, accepted: Type == "Accept", token))
|
||||
{
|
||||
Arrival.Accept("relay-answer");
|
||||
return;
|
||||
}
|
||||
var following = await FindFollowing(activity["object"], actor, _dbEntities, _localActors, token);
|
||||
var following = await FindFollowing(activity["object"], actor, db, localActorService, token);
|
||||
if (following == default)
|
||||
{
|
||||
Arrival.Drop("unknown-object");
|
||||
@@ -73,8 +60,8 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
protected virtual async Task Apply(Following following, CancellationToken token)
|
||||
{
|
||||
await DB.Default.Update<Following>().MatchID(following.ID).Modify(f => f.State, FollowState.Accepted).ExecuteAsync(token);
|
||||
if (_queue != default)
|
||||
await _queue.Enqueue(Models.Jobs.JobKind.BackfillOutbox, following.TargetActorURI, new Uri(following.TargetActorURI).Host,
|
||||
if (queue != default)
|
||||
await queue.Enqueue(Models.Jobs.JobKind.BackfillOutbox, following.TargetActorURI, new Uri(following.TargetActorURI).Host,
|
||||
Actors.OutboxBackfill.DedupeKey(following.TargetActorURI, DateTime.UtcNow), token);
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user