House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -17,22 +17,15 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
// A remote account blocks one of our personas, as Mastodon does it: the follows between them end here too (the blocker
|
||||
// already ended its side, so nothing is sent back), the persona stops seeing the blocker's posts and notifications, the
|
||||
// relationship says blocked_by, and nothing of the persona's is addressed to the blocker any more. Undo{Block} lifts it.
|
||||
public class BlockHandler : IActivityHandler
|
||||
public class BlockHandler(
|
||||
DbEntities dbEntities,
|
||||
ILocalActorService localActorService) : IActivityHandler
|
||||
{
|
||||
readonly DbEntities _dbEntities;
|
||||
readonly ILocalActorService _localActors;
|
||||
|
||||
public BlockHandler(DbEntities dbEntities, ILocalActorService localActors)
|
||||
{
|
||||
_dbEntities = dbEntities;
|
||||
_localActors = localActors;
|
||||
}
|
||||
|
||||
public string Type => "Block";
|
||||
|
||||
public async Task Handle(JsonNode activity, ForeignAvatar actor, CancellationToken token)
|
||||
{
|
||||
var target = Id(activity["object"]) is { } uri ? await _localActors.FindByUri(uri, token) : default;
|
||||
var target = Id(activity["object"]) is { } uri ? await localActorService.FindByUri(uri, token) : default;
|
||||
if (target is not { Kind: LocalActorKind.Person })
|
||||
{
|
||||
Arrival.Drop("unknown-object");
|
||||
@@ -70,7 +63,7 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
|
||||
async Task Ban(JsonNode activity, LocalActor persona, string communityUri, CancellationToken token)
|
||||
{
|
||||
var community = await _dbEntities.ForeignAvatars.Match(f => f.ActorURI == communityUri && f.AvatarType == AvatarType.Group).ExecuteFirstAsync(token);
|
||||
var community = await dbEntities.ForeignAvatars.Match(f => f.ActorURI == communityUri && f.AvatarType == AvatarType.Group).ExecuteFirstAsync(token);
|
||||
if (community == default)
|
||||
{
|
||||
Arrival.Drop("unknown-community");
|
||||
|
||||
Reference in new issue
Block a user