House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -26,45 +26,22 @@ using PostEntity = PrivaPub.Models.Post.Post;
|
||||
|
||||
namespace PrivaPub.Federation.Inbox.Handlers
|
||||
{
|
||||
public class CreateHandler : IActivityHandler
|
||||
public class CreateHandler(
|
||||
DbEntities dbEntities,
|
||||
ILocalActorService localActors,
|
||||
IRemoteActorService remoteActors,
|
||||
IDeliveryService delivery,
|
||||
IFanout fanout,
|
||||
IRemotePosts remotePosts,
|
||||
IGroupDistributor groups,
|
||||
IObjectRecords records,
|
||||
IPollService polls,
|
||||
ILinkPreviews previews,
|
||||
IQuoteService quotes,
|
||||
IInteractionApprovals approvals = default,
|
||||
Relays.IRelays relays = default,
|
||||
IWalls walls = default) : IActivityHandler
|
||||
{
|
||||
readonly DbEntities _dbEntities;
|
||||
readonly ILocalActorService _localActors;
|
||||
readonly IRemoteActorService _remoteActors;
|
||||
readonly IDeliveryService _delivery;
|
||||
readonly IDomainBlocks _domainBlocks;
|
||||
readonly IFanout _fanout;
|
||||
readonly IRemotePosts _remotePosts;
|
||||
readonly IGroupDistributor _groups;
|
||||
readonly IObjectRecords _records;
|
||||
readonly IPollService _polls;
|
||||
readonly ILinkPreviews _previews;
|
||||
readonly IQuoteService _quotes;
|
||||
readonly IInteractionApprovals _approvals;
|
||||
readonly Relays.IRelays _relays;
|
||||
readonly IWalls _walls;
|
||||
|
||||
public CreateHandler(DbEntities dbEntities, ILocalActorService localActors, IRemoteActorService remoteActors, IDeliveryService delivery,
|
||||
IDomainBlocks domainBlocks, IFanout fanout, IRemotePosts remotePosts, IGroupDistributor groups, IObjectRecords records, IPollService polls, ILinkPreviews previews, IQuoteService quotes,
|
||||
IInteractionApprovals approvals = default, Relays.IRelays relays = default, IWalls walls = default)
|
||||
{
|
||||
_walls = walls;
|
||||
_relays = relays;
|
||||
_approvals = approvals;
|
||||
_quotes = quotes;
|
||||
_previews = previews;
|
||||
_records = records;
|
||||
_polls = polls;
|
||||
_groups = groups;
|
||||
_fanout = fanout;
|
||||
_remotePosts = remotePosts;
|
||||
_dbEntities = dbEntities;
|
||||
_localActors = localActors;
|
||||
_remoteActors = remoteActors;
|
||||
_delivery = delivery;
|
||||
_domainBlocks = domainBlocks;
|
||||
}
|
||||
|
||||
public string Type => "Create";
|
||||
|
||||
public async Task Handle(JsonNode activity, ForeignAvatar author, CancellationToken token)
|
||||
@@ -73,7 +50,7 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
var refetched = node is not JsonObject || !Origin.Same(Id(node), author.ActorURI);
|
||||
if (refetched)
|
||||
{
|
||||
using var fetched = await _remoteActors.FetchObject(Id(node), token);
|
||||
using var fetched = await remoteActors.FetchObject(Id(node), token);
|
||||
node = fetched == default ? default : JsonNode.Parse(fetched.Root.GetRawText());
|
||||
if (node == default)
|
||||
Arrival.Drop("fetch-failed");
|
||||
@@ -85,11 +62,11 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
{
|
||||
if (!refetched)
|
||||
{
|
||||
using var fetched = await _remoteActors.FetchObject(note.Id, token);
|
||||
using var fetched = await remoteActors.FetchObject(note.Id, token);
|
||||
note = fetched == default ? default : NoteParser.Parse(JsonNode.Parse(fetched.Root.GetRawText()));
|
||||
refetched = true;
|
||||
}
|
||||
author = note == default ? default : await _remoteActors.GetActor(note.AttributedTo, refresh: false, token);
|
||||
author = note == default ? default : await remoteActors.GetActor(note.AttributedTo, refresh: false, token);
|
||||
if (author == default)
|
||||
{
|
||||
Arrival.Drop(note == default ? "fetch-failed" : "author-unavailable");
|
||||
@@ -104,16 +81,16 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
Arrival.About(note.Type);
|
||||
if (note.Title != default && note.InReplyTo != default && ObjectShapes.Text(note.ContentHtml, 1) == default)
|
||||
{
|
||||
var question = await _dbEntities.Posts.Match(p => p.ObjectURI == note.InReplyTo && p.Poll != null).ExecuteFirstAsync(token);
|
||||
var question = await dbEntities.Posts.Match(p => p.ObjectURI == note.InReplyTo && p.Poll != null).ExecuteFirstAsync(token);
|
||||
if (question != default)
|
||||
{
|
||||
await _polls.Receive(question, author, note.Title, Id(activity), token);
|
||||
await polls.Receive(question, author, note.Title, Id(activity), token);
|
||||
Arrival.Accept("poll-vote");
|
||||
Arrival.About(visibility: question.Visibility);
|
||||
return;
|
||||
}
|
||||
}
|
||||
if (await _dbEntities.Posts.Match(p => p.ObjectURI == note.Id).ExecuteAnyAsync(token))
|
||||
if (await dbEntities.Posts.Match(p => p.ObjectURI == note.Id).ExecuteAnyAsync(token))
|
||||
{
|
||||
Arrival.Drop("duplicate");
|
||||
return;
|
||||
@@ -146,7 +123,7 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
var localTargets = new List<LocalActor>();
|
||||
for (var i = 0; i < addressed.Count; i++)
|
||||
{
|
||||
var local = await _localActors.FindByAddress(addressed[i], token);
|
||||
var local = await localActors.FindByAddress(addressed[i], token);
|
||||
if (local == default)
|
||||
continue;
|
||||
addressed[i] = local.Uri;
|
||||
@@ -158,9 +135,9 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
|
||||
var parent = string.IsNullOrEmpty(note.InReplyTo)
|
||||
? default
|
||||
: await _dbEntities.Posts.Match(p => p.ObjectURI == note.InReplyTo && !p.DeletedAt.HasValue).ExecuteFirstAsync(token);
|
||||
: await dbEntities.Posts.Match(p => p.ObjectURI == note.InReplyTo && !p.DeletedAt.HasValue).ExecuteFirstAsync(token);
|
||||
// a reply its parent's author has not let in (GoToSocial's canReply), which a third party must not show
|
||||
if (_approvals != default && parent != default && !await _approvals.MayReply(note, author, parent, token))
|
||||
if (approvals != default && parent != default && !await approvals.MayReply(note, author, parent, token))
|
||||
{
|
||||
Arrival.Drop("reply-not-authorized");
|
||||
return;
|
||||
@@ -183,26 +160,26 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
group = default;
|
||||
|
||||
var repliesToLocal = parent is { IsFederatedCopy: false } && visibility != PostVisibility.Direct;
|
||||
var followed = visibility != PostVisibility.Direct && await _dbEntities.Followings
|
||||
var followed = visibility != PostVisibility.Direct && await dbEntities.Followings
|
||||
.Match(f => f.TargetActorURI == author.ActorURI && f.State == FollowState.Accepted)
|
||||
.ExecuteAnyAsync(token);
|
||||
// a reply in the thread of someone followed here, as Mastodon keeps them: what the thread's server forwards
|
||||
var repliesToFollowed = !followed && parent is { IsFederatedCopy: true } && visibility is PostVisibility.Public or PostVisibility.Unlisted
|
||||
&& await _dbEntities.Followings.Match(f => f.TargetActorURI == parent.ActorURI && f.State == FollowState.Accepted).ExecuteAnyAsync(token);
|
||||
&& await dbEntities.Followings.Match(f => f.TargetActorURI == parent.ActorURI && f.State == FollowState.Accepted).ExecuteAnyAsync(token);
|
||||
// a post in a remote group followed here that the group's own server sends itself rather than announcing it (Mbin
|
||||
// delivers a magazine's threads to its subscribers as their author's Create): the group's server speaks for it
|
||||
var inFollowedGroup = !followed && visibility is PostVisibility.Public or PostVisibility.Unlisted && note.Audience != default
|
||||
&& Origin.Same(note.Audience, author.ActorURI) && Origin.Same(note.Id, note.Audience)
|
||||
&& await _dbEntities.Followings.Match(f => f.TargetActorURI == note.Audience && f.State == FollowState.Accepted).ExecuteAnyAsync(token);
|
||||
&& await dbEntities.Followings.Match(f => f.TargetActorURI == note.Audience && f.State == FollowState.Accepted).ExecuteAnyAsync(token);
|
||||
// a public post a relay we subscribe to passes on, for the federated timeline (read again from its origin, as any
|
||||
// forwarded post)
|
||||
var relayed = !followed && visibility == PostVisibility.Public && _relays != default
|
||||
&& await _relays.Passes(Arrival.Current?.ForwardedBy, token);
|
||||
var relayed = !followed && visibility == PostVisibility.Public && relays != default
|
||||
&& await relays.Passes(Arrival.Current?.ForwardedBy, token);
|
||||
// written on a persona's wall (FEP-400e): public, not a reply, by an account following the persona, as its actor
|
||||
// tells Smithereen
|
||||
var wall = _walls == default || note.Wall == default ? default : await _walls.OwnerOf(note.Wall, token);
|
||||
var wall = walls == default || note.Wall == default ? default : await walls.OwnerOf(note.Wall, token);
|
||||
if (wall != default && (visibility is not (PostVisibility.Public or PostVisibility.Unlisted) || !string.IsNullOrEmpty(note.InReplyTo)
|
||||
|| note.WallOwner != default && note.WallOwner != wall.Uri || !await _walls.MayWrite(wall, author, token)))
|
||||
|| note.WallOwner != default && note.WallOwner != wall.Uri || !await walls.MayWrite(wall, author, token)))
|
||||
{
|
||||
Arrival.Drop("wall-refused");
|
||||
return;
|
||||
@@ -214,7 +191,7 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
return;
|
||||
}
|
||||
if (parent == default && visibility != PostVisibility.Direct)
|
||||
parent = await _remotePosts.Parent(note.InReplyTo, 1, token);
|
||||
parent = await remotePosts.Parent(note.InReplyTo, 1, token);
|
||||
|
||||
DmGroup conversation = default;
|
||||
if (visibility == PostVisibility.Direct)
|
||||
@@ -226,7 +203,7 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
conversation = await FindOrCreateConversation(participants, Origin.Same(note.Context, author.ActorURI) ? note.Context : default, token);
|
||||
}
|
||||
|
||||
var post = await _remotePosts.Build(note, author, visibility, to, cc, parent, token);
|
||||
var post = await remotePosts.Build(note, author, visibility, to, cc, parent, token);
|
||||
post.ActivityURI = Id(activity);
|
||||
post.GroupId = group?.Id;
|
||||
post.ConversationId = conversation?.ID;
|
||||
@@ -247,31 +224,31 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
}
|
||||
Arrival.Accept("stored");
|
||||
Arrival.About(local: group ?? persons.FirstOrDefault());
|
||||
await _records.Record(note, post, ObjectPath.Delivered, refetched, token);
|
||||
await _previews.Wanted(post, token);
|
||||
await _quotes.Resolve(post, note, token);
|
||||
await records.Record(note, post, ObjectPath.Delivered, refetched, token);
|
||||
await previews.Wanted(post, token);
|
||||
await quotes.Resolve(post, note, token);
|
||||
|
||||
if (parent != default && Domain.Privacy.Counted.Reply(post))
|
||||
await DB.Default.Update<PostEntity>().MatchID(parent.ID).Modify(b => b.Inc(p => p.RepliesCount, 1)).ExecuteAsync(token);
|
||||
await _fanout.Distribute(post, token);
|
||||
await ReplyRelay.Pass(post, _dbEntities, _localActors, _delivery, token);
|
||||
await fanout.Distribute(post, token);
|
||||
await ReplyRelay.Pass(post, dbEntities, localActors, delivery, token);
|
||||
if (conversation != default)
|
||||
{
|
||||
await Domain.Statuses.ConversationStates.Posted(conversation.ID, post.ID, default, token);
|
||||
await Domain.Timelines.Fanout.Conversation(conversation.ID, token);//the `direct` streams (R8), once it is the newest
|
||||
}
|
||||
if (group is { IsCircle: false })
|
||||
await _groups.Announce(group, activity.AsObject(), note.Id, isNewPost: true, token);
|
||||
await groups.Announce(group, activity.AsObject(), note.Id, isNewPost: true, token);
|
||||
if (wall != default)
|
||||
await _walls.Hosted(post, wall, token);
|
||||
await walls.Hosted(post, wall, token);
|
||||
}
|
||||
|
||||
async Task<bool> IsCircleMember(LocalActor circle, string actorUri, CancellationToken token) =>
|
||||
await _dbEntities.Groups.Match(g => g.ID == circle.Id && g.Members.Any(m => m.IsForeign && m.AvatarId == actorUri)).ExecuteAnyAsync(token);
|
||||
await dbEntities.Groups.Match(g => g.ID == circle.Id && g.Members.Any(m => m.IsForeign && m.AvatarId == actorUri)).ExecuteAnyAsync(token);
|
||||
|
||||
async Task<bool> MayPost(LocalActor community, string actorUri, CancellationToken token)
|
||||
{
|
||||
var entity = await _dbEntities.Groups.MatchID(community.Id).ExecuteFirstAsync(token);
|
||||
var entity = await dbEntities.Groups.MatchID(community.Id).ExecuteFirstAsync(token);
|
||||
return entity?.PostingPolicy switch
|
||||
{
|
||||
PostingPolicy.Anyone => true,
|
||||
@@ -285,7 +262,7 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
var members = new List<GroupMember>();
|
||||
foreach (var uri in participantUris.Distinct(StringComparer.Ordinal))
|
||||
{
|
||||
var local = await _localActors.FindByUri(uri, token);
|
||||
var local = await localActors.FindByUri(uri, token);
|
||||
var member = local != default && local.Kind == LocalActorKind.Person
|
||||
? new GroupMember { AvatarId = local.Id }
|
||||
: new GroupMember { AvatarId = uri, IsForeign = true };
|
||||
@@ -294,7 +271,7 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
}
|
||||
|
||||
var key = DmGroup.KeyOf(members);
|
||||
var match = await _dbEntities.DmGroups.Match(g => g.ParticipantsKey == key && !g.DeletionAt.HasValue).ExecuteFirstAsync(token);
|
||||
var match = await dbEntities.DmGroups.Match(g => g.ParticipantsKey == key && !g.DeletionAt.HasValue).ExecuteFirstAsync(token);
|
||||
if (match != default)
|
||||
return match;
|
||||
|
||||
|
||||
Reference in new issue
Block a user