House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -10,51 +10,39 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
// its `featured` collection (as Mastodon sends it) or its `featuredTags` is a featured tag (R8). On its wall
|
||||
// (Smithereen's, FEP-400e) it tells of a post someone wrote there, or takes it off. Any other target (a community's
|
||||
// moderators) is not ours to keep.
|
||||
public class FeaturedHandler : IActivityHandler
|
||||
public class FeaturedHandler(
|
||||
IFeaturedPosts featuredPosts,
|
||||
bool add,
|
||||
IWalls walls = default,
|
||||
IRemoteActorService remoteActors = default,
|
||||
Infrastructure.Jobs.IJobQueue queue = default,
|
||||
Domain.Social.IFeaturedTags tags = default) : IActivityHandler
|
||||
{
|
||||
readonly IFeaturedPosts _featured;
|
||||
readonly IWalls _walls;
|
||||
readonly IRemoteActorService _remoteActors;
|
||||
readonly Infrastructure.Jobs.IJobQueue _queue;
|
||||
readonly Domain.Social.IFeaturedTags _tags;
|
||||
readonly bool _add;
|
||||
|
||||
public FeaturedHandler(IFeaturedPosts featured, bool add, IWalls walls = default, IRemoteActorService remoteActors = default,
|
||||
Infrastructure.Jobs.IJobQueue queue = default, Domain.Social.IFeaturedTags tags = default)
|
||||
{
|
||||
_tags = tags;
|
||||
_featured = featured;
|
||||
_walls = walls;
|
||||
_remoteActors = remoteActors;
|
||||
_queue = queue;
|
||||
_add = add;
|
||||
}
|
||||
|
||||
public string Type => _add ? "Add" : "Remove";
|
||||
public string Type => add ? "Add" : "Remove";
|
||||
|
||||
public async Task Handle(JsonNode activity, ForeignAvatar actor, CancellationToken token)
|
||||
{
|
||||
if (_add && _queue != default && await ConversationContainers.Unwrap(activity, actor, _queue, token))
|
||||
if (add && queue != default && await ConversationContainers.Unwrap(activity, actor, queue, token))
|
||||
return;
|
||||
var target = Objects.ActivityJson.Id(activity["target"]);
|
||||
// a collection of its own we do not know of: its document read again, at most hourly, in case it was kept before
|
||||
// we read that collection (a wall)
|
||||
if (_remoteActors != default && target != default && target != actor.FeaturedURL && target != actor.WallURL && target != actor.FeaturedTagsURL
|
||||
if (remoteActors != default && target != default && target != actor.FeaturedURL && target != actor.WallURL && target != actor.FeaturedTagsURL
|
||||
&& Objects.Origin.Same(target, actor.ActorURI) && actor.UpdatedAt < DateTime.UtcNow.AddHours(-1))
|
||||
actor = await _remoteActors.GetActor(actor.ActorURI, refresh: true, token) ?? actor;
|
||||
actor = await remoteActors.GetActor(actor.ActorURI, refresh: true, token) ?? actor;
|
||||
// a featured hashtag: an object of its own, with no id (its href is no post), so before anything reads it as one
|
||||
if (Objects.ActivityJson.Value(activity["object"], "type") == "Hashtag")
|
||||
{
|
||||
if (_tags != default && target != default && (target == actor.FeaturedURL || target == actor.FeaturedTagsURL))
|
||||
await _tags.Receive(activity, actor, _add, token);
|
||||
if (tags != default && target != default && (target == actor.FeaturedURL || target == actor.FeaturedTagsURL))
|
||||
await tags.Receive(activity, actor, add, token);
|
||||
else
|
||||
Arrival.Drop("unknown-target");
|
||||
return;
|
||||
}
|
||||
if (_walls != default && !string.IsNullOrEmpty(actor.WallURL) && target == actor.WallURL)
|
||||
await _walls.Receive(activity, actor, _add, token);
|
||||
if (walls != default && !string.IsNullOrEmpty(actor.WallURL) && target == actor.WallURL)
|
||||
await walls.Receive(activity, actor, add, token);
|
||||
else
|
||||
await _featured.Receive(activity, actor, _add, token);
|
||||
await featuredPosts.Receive(activity, actor, add, token);
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user