House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -16,17 +16,10 @@ using PostEntity = PrivaPub.Models.Post.Post;
|
||||
|
||||
namespace PrivaPub.Federation.Inbox.Handlers
|
||||
{
|
||||
public class LikeHandler : IActivityHandler
|
||||
public class LikeHandler(
|
||||
DbEntities dbEntities,
|
||||
IReactions reactions) : IActivityHandler
|
||||
{
|
||||
readonly DbEntities _dbEntities;
|
||||
readonly IReactions _reactions;
|
||||
|
||||
public LikeHandler(DbEntities dbEntities, IReactions reactions)
|
||||
{
|
||||
_dbEntities = dbEntities;
|
||||
_reactions = reactions;
|
||||
}
|
||||
|
||||
public string Type => "Like";
|
||||
|
||||
public async Task Handle(JsonNode activity, ForeignAvatar actor, CancellationToken token)
|
||||
@@ -34,7 +27,7 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
var objectUri = Id(activity["object"]);
|
||||
var post = objectUri == default
|
||||
? default
|
||||
: await _dbEntities.Posts.Match(p => p.ObjectURI == objectUri && !p.DeletedAt.HasValue && p.ReblogOfPostId == null).ExecuteFirstAsync(token);
|
||||
: await dbEntities.Posts.Match(p => p.ObjectURI == objectUri && !p.DeletedAt.HasValue && p.ReblogOfPostId == null).ExecuteFirstAsync(token);
|
||||
if (post == default || !await VisibilityPolicy.RemoteCanSee(post, actor, token))
|
||||
{
|
||||
Arrival.Drop(post == default ? "unknown-object" : "not-visible");
|
||||
@@ -44,7 +37,7 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
var content = Value(activity, "_misskey_reaction") ?? Value(activity, "content");
|
||||
if (!Reactions.IsHeart(content))
|
||||
{
|
||||
await _reactions.Receive(post, actor, content, activity["tag"], Id(activity), token);
|
||||
await reactions.Receive(post, actor, content, activity["tag"], Id(activity), token);
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -64,7 +57,7 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
&& (await DB.Default.DeleteAsync<Downvote>(downvoted.ID)).DeletedCount > 0)
|
||||
await DB.Default.Update<PostEntity>().MatchID(post.ID).Modify(b => b.Inc(p => p.DownvotesCount, -1)).ExecuteAsync(token);
|
||||
if (!post.IsFederatedCopy)
|
||||
await Notifications.Add(post.GroupUserId, NotificationType.Favourite, actor.ID, actor.ActorURI, post.ID, token);
|
||||
await Notifications.Add(post.GroupUserId, NotificationType.Favourite, actor.ID, actor.ActorURI, post.ID, token: token);
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user