House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -20,24 +20,13 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
// it among its alsoKnownAs. The old account then shows where it went (`moved`), and, as Mastodon does it (owner
|
||||
// decision 2026-10-05), the personas following it follow the new one instead, in the same lists, and those that
|
||||
// muted or blocked it mute or block the new one too.
|
||||
public class MoveHandler : IActivityHandler
|
||||
public class MoveHandler(
|
||||
IRemoteActorService remoteActors,
|
||||
DbEntities dbEntities,
|
||||
ILocalActorService localActors,
|
||||
IFollowService follows,
|
||||
IRelationshipService relationships) : IActivityHandler
|
||||
{
|
||||
readonly IRemoteActorService _remoteActors;
|
||||
readonly DbEntities _dbEntities;
|
||||
readonly ILocalActorService _localActors;
|
||||
readonly IFollowService _follows;
|
||||
readonly IRelationshipService _relationships;
|
||||
|
||||
public MoveHandler(IRemoteActorService remoteActors, DbEntities dbEntities, ILocalActorService localActors, IFollowService follows,
|
||||
IRelationshipService relationships)
|
||||
{
|
||||
_remoteActors = remoteActors;
|
||||
_dbEntities = dbEntities;
|
||||
_localActors = localActors;
|
||||
_follows = follows;
|
||||
_relationships = relationships;
|
||||
}
|
||||
|
||||
public string Type => "Move";
|
||||
|
||||
public async Task Handle(JsonNode activity, ForeignAvatar actor, CancellationToken token)
|
||||
@@ -48,7 +37,7 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
Arrival.Drop("not-self");
|
||||
return;
|
||||
}
|
||||
var moved = await _remoteActors.GetActor(target, refresh: true, token);
|
||||
var moved = await remoteActors.GetActor(target, refresh: true, token);
|
||||
if (moved == default)
|
||||
{
|
||||
Arrival.Drop("target-unavailable");
|
||||
@@ -67,15 +56,15 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
|
||||
async Task MoveFollows(ForeignAvatar old, ForeignAvatar moved, CancellationToken token)
|
||||
{
|
||||
foreach (var following in await _dbEntities.Followings.Match(f => f.TargetActorURI == old.ActorURI).ExecuteAsync(token))
|
||||
foreach (var following in await dbEntities.Followings.Match(f => f.TargetActorURI == old.ActorURI).ExecuteAsync(token))
|
||||
{
|
||||
var persona = await _localActors.FindById(LocalActorKind.Person, following.AvatarId, token);
|
||||
var persona = await localActors.FindById(LocalActorKind.Person, following.AvatarId, token);
|
||||
if (persona == default)
|
||||
continue;
|
||||
var lists = await DB.Default.Find<PersonaListMember>().Match(m => m.AvatarId == persona.Id && m.AccountId == old.ID).ExecuteAsync(token);
|
||||
var endorsed = await DB.Default.Find<Endorsement>().Match(e => e.AvatarId == persona.Id && e.TargetActorURI == old.ActorURI).ExecuteAnyAsync(token);
|
||||
var followed = await _follows.FollowAs(persona, moved.ActorURI, following.ShowReblogs, token, following.Notify, following.Languages ?? new List<string>());
|
||||
await _follows.UnfollowAs(persona, old.ActorURI, token);
|
||||
var followed = await follows.FollowAs(persona, moved.ActorURI, following.ShowReblogs, following.Notify, following.Languages ?? new List<string>(), token);
|
||||
await follows.UnfollowAs(persona, old.ActorURI, token);
|
||||
if (followed == default)
|
||||
continue;
|
||||
// the persona's endorsement and private note go with the follow, as Mastodon carries them over (R8)
|
||||
@@ -100,14 +89,14 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
async Task CarryOver(ForeignAvatar old, ForeignAvatar moved, CancellationToken token)
|
||||
{
|
||||
foreach (var mute in await DB.Default.Find<Mute>().Match(m => m.TargetActorURI == old.ActorURI).ExecuteAsync(token))
|
||||
if (await _localActors.FindById(LocalActorKind.Person, mute.AvatarId, token) is { } persona
|
||||
if (await localActors.FindById(LocalActorKind.Person, mute.AvatarId, token) is { } persona
|
||||
&& !await DB.Default.Find<Mute>().Match(m => m.AvatarId == persona.Id && m.TargetActorURI == moved.ActorURI).ExecuteAnyAsync(token))
|
||||
await _relationships.Mute(persona, moved.ActorURI, moved.ID, mute.HideNotifications,
|
||||
await relationships.Mute(persona, moved.ActorURI, moved.ID, mute.HideNotifications,
|
||||
mute.ExpiresAt is { } expires ? expires - DateTime.UtcNow : default(TimeSpan?), token);
|
||||
foreach (var block in await DB.Default.Find<Block>().Match(b => b.TargetActorURI == old.ActorURI).ExecuteAsync(token))
|
||||
if (await _localActors.FindById(LocalActorKind.Person, block.AvatarId, token) is { } persona
|
||||
if (await localActors.FindById(LocalActorKind.Person, block.AvatarId, token) is { } persona
|
||||
&& !await DB.Default.Find<Block>().Match(b => b.AvatarId == persona.Id && b.TargetActorURI == moved.ActorURI).ExecuteAnyAsync(token))
|
||||
await _relationships.Block(persona, moved.ActorURI, moved.ID, token);
|
||||
await relationships.Block(persona, moved.ActorURI, moved.ID, token);
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user