House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -15,18 +15,12 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
// Lemmy 1.0 tells a report's sender that it was dealt with: Resolve{Flag}, the Flag being one we sent
|
||||
// (`/grunts/flag-<report id>`). It is believed from the server holding what was reported, or the community it was
|
||||
// reported to, and kept on the report beside our own moderators' resolution, which it never replaces.
|
||||
public class ResolveHandler : IActivityHandler
|
||||
public class ResolveHandler(
|
||||
DbEntities dbEntities,
|
||||
ILocalActorService localActors) : IActivityHandler
|
||||
{
|
||||
const string FlagMarker = "/grunts/flag-";
|
||||
|
||||
readonly DbEntities _dbEntities;
|
||||
readonly ILocalActorService _localActors;
|
||||
|
||||
public ResolveHandler(DbEntities dbEntities, ILocalActorService localActors)
|
||||
{
|
||||
_dbEntities = dbEntities;
|
||||
_localActors = localActors;
|
||||
}
|
||||
|
||||
public string Type => "Resolve";
|
||||
|
||||
@@ -36,7 +30,7 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
var flagId = Id(flag);
|
||||
var marker = flagId?.IndexOf(FlagMarker, StringComparison.Ordinal) ?? -1;
|
||||
if (flag is JsonObject && Value(flag, "type") != "Flag" || marker < 0
|
||||
|| !flagId.StartsWith(_localActors.BaseAddress + "/", StringComparison.OrdinalIgnoreCase))
|
||||
|| !flagId.StartsWith(localActors.BaseAddress + "/", StringComparison.OrdinalIgnoreCase))
|
||||
{
|
||||
Arrival.Drop("not-ours");
|
||||
return;
|
||||
@@ -49,8 +43,8 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
return;
|
||||
}
|
||||
var concerned = new List<string>(report.ObjectURIs) { report.TargetActorURI };
|
||||
foreach (var post in report.PostIds.Count == 0 ? new List<Models.Post.Post>() : await _dbEntities.Posts.Match(p => report.PostIds.Contains(p.ID)).ExecuteAsync(token))
|
||||
concerned.Add(await Communities.Of(post, _dbEntities, token));
|
||||
foreach (var post in report.PostIds.Count == 0 ? new List<Models.Post.Post>() : await dbEntities.Posts.Match(p => report.PostIds.Contains(p.ID)).ExecuteAsync(token))
|
||||
concerned.Add(await Communities.Of(post, dbEntities, token));
|
||||
if (!concerned.Any(uri => Origin.Same(uri, actor.ActorURI)))
|
||||
{
|
||||
Arrival.Drop("misattributed");
|
||||
|
||||
Reference in new issue
Block a user