House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -17,20 +17,13 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
// [persona], object: post, summary: reason, audience: community}), sent to the persona's inbox alone. It becomes the
|
||||
// persona's moderation_warning notification, once the sender is shown to moderate that community and the post is the
|
||||
// persona's own, in it.
|
||||
public class WarnHandler : IActivityHandler
|
||||
public class WarnHandler(
|
||||
DbEntities dbEntities,
|
||||
ILocalActorService localActors,
|
||||
IRemoteActorService remoteActors) : IActivityHandler
|
||||
{
|
||||
const int MaxReason = 1000;
|
||||
|
||||
readonly DbEntities _dbEntities;
|
||||
readonly ILocalActorService _localActors;
|
||||
readonly IRemoteActorService _remoteActors;
|
||||
|
||||
public WarnHandler(DbEntities dbEntities, ILocalActorService localActors, IRemoteActorService remoteActors)
|
||||
{
|
||||
_dbEntities = dbEntities;
|
||||
_localActors = localActors;
|
||||
_remoteActors = remoteActors;
|
||||
}
|
||||
|
||||
public string Type => "Warn";
|
||||
|
||||
@@ -38,7 +31,7 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
{
|
||||
LocalActor persona = default;
|
||||
foreach (var uri in Recipients(activity["to"]))
|
||||
if (await _localActors.FindByUri(uri, token) is { Kind: LocalActorKind.Person } found)
|
||||
if (await localActors.FindByUri(uri, token) is { Kind: LocalActorKind.Person } found)
|
||||
{
|
||||
persona = found;
|
||||
break;
|
||||
@@ -49,7 +42,7 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
return;
|
||||
}
|
||||
var communityUri = Id(activity["audience"]);
|
||||
var community = communityUri == default ? default : await _remoteActors.GetActor(communityUri, refresh: false, token);
|
||||
var community = communityUri == default ? default : await remoteActors.GetActor(communityUri, refresh: false, token);
|
||||
if (community is not { AvatarType: AvatarType.Group })
|
||||
{
|
||||
Arrival.Drop("unknown-community");
|
||||
@@ -58,21 +51,21 @@ namespace PrivaPub.Federation.Inbox.Handlers
|
||||
var objectUri = Id(activity["object"]);
|
||||
var post = objectUri == default
|
||||
? default
|
||||
: await _dbEntities.Posts.Match(p => p.ObjectURI == objectUri && p.GroupUserId == persona.Id && !p.IsFederatedCopy).ExecuteFirstAsync(token);
|
||||
if (post == default || await Communities.Of(post, _dbEntities, token) != community.ActorURI)
|
||||
: await dbEntities.Posts.Match(p => p.ObjectURI == objectUri && p.GroupUserId == persona.Id && !p.IsFederatedCopy).ExecuteFirstAsync(token);
|
||||
if (post == default || await Communities.Of(post, dbEntities, token) != community.ActorURI)
|
||||
{
|
||||
Arrival.Drop("unknown-object");
|
||||
return;
|
||||
}
|
||||
Arrival.About(visibility: post.Visibility, created: post.CreationDate, local: persona);
|
||||
if (!await Communities.Moderates(community, actor.ActorURI, _remoteActors, token))
|
||||
if (!await Communities.Moderates(community, actor.ActorURI, remoteActors, token))
|
||||
{
|
||||
Arrival.Drop("not-moderator");
|
||||
return;
|
||||
}
|
||||
var reason = Value(activity, "summary") ?? Value(activity, "content");
|
||||
await Notifications.Add(persona.Id, NotificationType.ModerationWarning, community.ID, community.ActorURI, post.ID, token,
|
||||
text: string.IsNullOrWhiteSpace(reason) ? default : reason.Trim().Length <= MaxReason ? reason.Trim() : reason.Trim()[..MaxReason]);
|
||||
await Notifications.Add(persona.Id, NotificationType.ModerationWarning, community.ID, community.ActorURI, post.ID,
|
||||
text: string.IsNullOrWhiteSpace(reason) ? default : reason.Trim().Length <= MaxReason ? reason.Trim() : reason.Trim()[..MaxReason], token: token);
|
||||
Arrival.Accept("warned");
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user