House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -31,29 +31,17 @@ namespace PrivaPub.Federation.Inbox
|
||||
Task<PostEntity> StoreContext(string objectUri, int depth, CancellationToken token);
|
||||
}
|
||||
|
||||
public class RemotePosts : IRemotePosts
|
||||
public class RemotePosts(
|
||||
DbEntities dbEntities,
|
||||
ILocalActorService localActorService,
|
||||
IRemoteActorService remoteActors,
|
||||
IDomainBlocks domainBlockList,
|
||||
IJobQueue queue,
|
||||
IObjectRecords records,
|
||||
ILinkPreviews previews) : IRemotePosts
|
||||
{
|
||||
public const int MaxDepth = 10;
|
||||
|
||||
readonly DbEntities _dbEntities;
|
||||
readonly ILocalActorService _localActors;
|
||||
readonly IRemoteActorService _remoteActors;
|
||||
readonly IDomainBlocks _domainBlocks;
|
||||
readonly IJobQueue _queue;
|
||||
readonly IObjectRecords _records;
|
||||
readonly ILinkPreviews _previews;
|
||||
|
||||
public RemotePosts(DbEntities dbEntities, ILocalActorService localActors, IRemoteActorService remoteActors, IDomainBlocks domainBlocks,
|
||||
IJobQueue queue, IObjectRecords records, ILinkPreviews previews)
|
||||
{
|
||||
_previews = previews;
|
||||
_records = records;
|
||||
_dbEntities = dbEntities;
|
||||
_localActors = localActors;
|
||||
_remoteActors = remoteActors;
|
||||
_domainBlocks = domainBlocks;
|
||||
_queue = queue;
|
||||
}
|
||||
|
||||
// The accounts a remote post names (its Mention tags), plus our personas it is addressed to without naming them: Mastodon
|
||||
// keeps those as silent mentions, and Akkoma's to[], or an edit that dropped the @name, address someone that way. A
|
||||
@@ -81,7 +69,7 @@ namespace PrivaPub.Federation.Inbox
|
||||
public async Task<PostEntity> Build(NoteDocument note, ForeignAvatar author, PostVisibility visibility, IReadOnlyList<string> to,
|
||||
IReadOnlyList<string> cc, PostEntity parent, CancellationToken token)
|
||||
{
|
||||
var mentions = await Mentions(note, to.Concat(cc), _localActors, token);
|
||||
var mentions = await Mentions(note, to.Concat(cc), localActorService, token);
|
||||
|
||||
var post = new PostEntity
|
||||
{
|
||||
@@ -127,7 +115,7 @@ namespace PrivaPub.Federation.Inbox
|
||||
Language = note.Language,
|
||||
Mentions = mentions,
|
||||
Tags = note.Tags.ToList(),
|
||||
Media = _domainBlocks.Find(new Uri(author.ActorURI).Host)?.RejectMedia == true ? new() : note.Attachments.ToList(),
|
||||
Media = domainBlockList.Find(new Uri(author.ActorURI).Host)?.RejectMedia == true ? new() : note.Attachments.ToList(),
|
||||
InReplyToURI = note.InReplyTo,
|
||||
AnsweringToPostId = parent?.ID,
|
||||
InReplyToAccountId = parent?.AuthorAccountId ?? parent?.GroupUserId,
|
||||
@@ -135,7 +123,7 @@ namespace PrivaPub.Federation.Inbox
|
||||
AuthorGone = author.AccountState == AvatarAccountState.Deleted,
|
||||
// the staff's moderation of its author or its server (R6), as AccountModeration sets it on what came before
|
||||
AuthorSuspended = author.SuspendedAt.HasValue,
|
||||
AuthorLimited = Limited(author, _domainBlocks),
|
||||
AuthorLimited = Limited(author, domainBlockList),
|
||||
CreationDate = note.Published,
|
||||
UpdateDate = note.Updated ?? note.Published,
|
||||
EditedAt = note.Updated,
|
||||
@@ -172,7 +160,7 @@ namespace PrivaPub.Federation.Inbox
|
||||
if (links.Count != 1 || links[0] == note.Id || !Origin.Same(links[0], author.ActorURI))
|
||||
return;
|
||||
using var scope = HttpScope.For("object");
|
||||
using var fetched = await _remoteActors.FetchObject(links[0], token);
|
||||
using var fetched = await remoteActors.FetchObject(links[0], token);
|
||||
var episode = fetched == default ? default : NoteParser.Parse(JsonNode.Parse(fetched.Root.GetRawText()));
|
||||
if (episode is not { Type: "PodcastEpisode" } || episode.AttributedTo != author.ActorURI)
|
||||
return;
|
||||
@@ -187,33 +175,33 @@ namespace PrivaPub.Federation.Inbox
|
||||
{
|
||||
if (string.IsNullOrEmpty(inReplyTo))
|
||||
return default;
|
||||
var known = await _dbEntities.Posts.Match(p => p.ObjectURI == inReplyTo && !p.DeletedAt.HasValue).ExecuteFirstAsync(token);
|
||||
if (known != default || inReplyTo.StartsWith(_localActors.BaseAddress + "/", StringComparison.OrdinalIgnoreCase))
|
||||
var known = await dbEntities.Posts.Match(p => p.ObjectURI == inReplyTo && !p.DeletedAt.HasValue).ExecuteFirstAsync(token);
|
||||
if (known != default || inReplyTo.StartsWith(localActorService.BaseAddress + "/", StringComparison.OrdinalIgnoreCase))
|
||||
return known;
|
||||
return await StoreContext(inReplyTo, depth, token);
|
||||
}
|
||||
|
||||
public async Task<PostEntity> StoreContext(string objectUri, int depth, CancellationToken token)
|
||||
{
|
||||
var existing = await _dbEntities.Posts.Match(p => p.ObjectURI == objectUri).ExecuteFirstAsync(token);
|
||||
var existing = await dbEntities.Posts.Match(p => p.ObjectURI == objectUri).ExecuteFirstAsync(token);
|
||||
if (existing != default || depth > MaxDepth || await DB.Default.Find<DeletedObject>().Match(d => d.ObjectURI == objectUri).ExecuteAnyAsync(token))
|
||||
return existing;
|
||||
|
||||
using var scope = HttpScope.For("context");
|
||||
using var fetched = await _remoteActors.FetchObject(objectUri, token);
|
||||
using var fetched = await remoteActors.FetchObject(objectUri, token);
|
||||
var note = fetched == default ? default : NoteParser.Parse(JsonNode.Parse(fetched.Root.GetRawText()));
|
||||
if (note == default || !Origin.Same(note.Id, note.AttributedTo))
|
||||
return default;
|
||||
var visibility = Addressing.Classify(note.To, note.Cc, default);
|
||||
if (visibility is not (PostVisibility.Public or PostVisibility.Unlisted))
|
||||
return default;
|
||||
var author = await _remoteActors.GetActor(note.AttributedTo, refresh: false, token);
|
||||
var author = await remoteActors.GetActor(note.AttributedTo, refresh: false, token);
|
||||
if (author == default)
|
||||
return default;
|
||||
|
||||
var grandparent = string.IsNullOrEmpty(note.InReplyTo)
|
||||
? default
|
||||
: await _dbEntities.Posts.Match(p => p.ObjectURI == note.InReplyTo && !p.DeletedAt.HasValue).ExecuteFirstAsync(token);
|
||||
: await dbEntities.Posts.Match(p => p.ObjectURI == note.InReplyTo && !p.DeletedAt.HasValue).ExecuteFirstAsync(token);
|
||||
var post = await Build(note, author, visibility, note.To, note.Cc, grandparent, token);
|
||||
try
|
||||
{
|
||||
@@ -221,29 +209,22 @@ namespace PrivaPub.Federation.Inbox
|
||||
}
|
||||
catch (MongoWriteException ex) when (ex.WriteError?.Category == ServerErrorCategory.DuplicateKey)
|
||||
{
|
||||
return await _dbEntities.Posts.Match(p => p.ObjectURI == objectUri).ExecuteFirstAsync(token);
|
||||
return await dbEntities.Posts.Match(p => p.ObjectURI == objectUri).ExecuteFirstAsync(token);
|
||||
}
|
||||
await _records.Record(note, post, ObjectPath.Fetched, refetched: false, token);
|
||||
await _previews.Wanted(post, token);
|
||||
await records.Record(note, post, ObjectPath.Fetched, refetched: false, token);
|
||||
await previews.Wanted(post, token);
|
||||
|
||||
if (grandparent == default && !string.IsNullOrEmpty(note.InReplyTo) && depth < MaxDepth)
|
||||
await _queue.Enqueue(JobKind.FetchAncestors, JsonSerializer.Serialize(new AncestorsPayload(post.ID, depth + 1)), new Uri(note.InReplyTo).Host,
|
||||
await queue.Enqueue(JobKind.FetchAncestors, JsonSerializer.Serialize(new AncestorsPayload(post.ID, depth + 1)), new Uri(note.InReplyTo).Host,
|
||||
"ancestors|" + post.ID, token);
|
||||
return post;
|
||||
}
|
||||
}
|
||||
|
||||
public class AncestorsJobHandler : IJobHandler
|
||||
public class AncestorsJobHandler(
|
||||
DbEntities dbEntities,
|
||||
IRemotePosts remotePosts) : IJobHandler
|
||||
{
|
||||
readonly DbEntities _dbEntities;
|
||||
readonly IRemotePosts _remotePosts;
|
||||
|
||||
public AncestorsJobHandler(DbEntities dbEntities, IRemotePosts remotePosts)
|
||||
{
|
||||
_dbEntities = dbEntities;
|
||||
_remotePosts = remotePosts;
|
||||
}
|
||||
|
||||
public JobKind Kind => JobKind.FetchAncestors;
|
||||
public int Concurrency => 1;
|
||||
public int MaxAttempts => 3;
|
||||
@@ -252,11 +233,11 @@ namespace PrivaPub.Federation.Inbox
|
||||
public async Task<JobOutcome> Handle(Job job, CancellationToken token)
|
||||
{
|
||||
var payload = JsonSerializer.Deserialize<AncestorsPayload>(job.Payload);
|
||||
var child = await _dbEntities.Posts.MatchID(payload.PostId).ExecuteFirstAsync(token);
|
||||
var child = await dbEntities.Posts.MatchID(payload.PostId).ExecuteFirstAsync(token);
|
||||
if (child == default || string.IsNullOrEmpty(child.InReplyToURI) || !string.IsNullOrEmpty(child.AnsweringToPostId))
|
||||
return JobOutcome.Done;
|
||||
|
||||
var parent = await _remotePosts.Parent(child.InReplyToURI, payload.Depth, token);
|
||||
var parent = await remotePosts.Parent(child.InReplyToURI, payload.Depth, token);
|
||||
if (parent == default)
|
||||
return JobOutcome.Done;
|
||||
await DB.Default.Update<PostEntity>().MatchID(child.ID)
|
||||
|
||||
Reference in new issue
Block a user