House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -21,15 +21,13 @@ namespace PrivaPub.Federation.Objects
|
||||
Task Revise(NoteDocument note, string activityId, CancellationToken token);
|
||||
}
|
||||
|
||||
public class ObjectRecords : IObjectRecords
|
||||
public class ObjectRecords(
|
||||
IJobQueue queue) : IObjectRecords
|
||||
{
|
||||
public const int MaxRawBytes = 256 * 1024;
|
||||
const int MaxRevisions = 10;
|
||||
static readonly TimeSpan DescriptionAge = TimeSpan.FromDays(7);
|
||||
|
||||
readonly IJobQueue _queue;
|
||||
|
||||
public ObjectRecords(IJobQueue queue) => _queue = queue;
|
||||
|
||||
public async Task Record(NoteDocument note, PostEntity post, ObjectPath path, bool refetched, CancellationToken token)
|
||||
{
|
||||
@@ -99,7 +97,7 @@ namespace PrivaPub.Federation.Objects
|
||||
var known = await DB.Default.Find<RemoteInstance>().Match(i => i.Host == host).ExecuteFirstAsync(token);
|
||||
if (known?.DescribedAt > DateTime.UtcNow - DescriptionAge)
|
||||
return;
|
||||
await _queue.Enqueue(JobKind.DescribeInstance, host, host, InstanceDescriber.DedupeKey(host, DateTime.UtcNow), token);
|
||||
await queue.Enqueue(JobKind.DescribeInstance, host, host, InstanceDescriber.DedupeKey(host, DateTime.UtcNow), token);
|
||||
}
|
||||
|
||||
public static (string Text, string Hash, int Bytes, bool Truncated) Capture(JsonNode raw)
|
||||
|
||||
Reference in new issue
Block a user