House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -16,7 +16,8 @@ namespace PrivaPub.Federation.Outbox
|
||||
Task Announce(LocalActor group, JsonObject activity, string objectUri, bool isNewPost, CancellationToken token);
|
||||
}
|
||||
|
||||
public class GroupDistributor : IGroupDistributor
|
||||
public class GroupDistributor(
|
||||
IDeliveryService delivery) : IGroupDistributor
|
||||
{
|
||||
// so the announce's id resolves (PeasantsController.Grunt); a repeat of the same announce keeps the first
|
||||
// a remote author's server's inbox (its shared one when it has one); none for our own personas
|
||||
@@ -48,12 +49,6 @@ namespace PrivaPub.Federation.Outbox
|
||||
}
|
||||
}
|
||||
|
||||
readonly IDeliveryService _delivery;
|
||||
|
||||
public GroupDistributor(IDeliveryService delivery)
|
||||
{
|
||||
_delivery = delivery;
|
||||
}
|
||||
|
||||
public async Task Announce(LocalActor group, JsonObject activity, string objectUri, bool isNewPost, CancellationToken token)
|
||||
{
|
||||
@@ -78,14 +73,14 @@ namespace PrivaPub.Federation.Outbox
|
||||
// its user's post pending until the community announces it back, and clears that before it answers the echo 400
|
||||
// ("Object is not remote").
|
||||
var authorsServer = await AuthorsInbox(activity, token);
|
||||
await _delivery.EnqueueToFollowers(group, announce, token, authorsServer);
|
||||
await delivery.EnqueueToFollowers(group, announce, authorsServer, token);
|
||||
await Keep(group, announce, objectUri, token);
|
||||
// a new post or comment is also boosted as itself: microblogs (Mastodon, Akkoma, Misskey) drop an Announce of an
|
||||
// activity, so without it their members never see what is said in the community; Lemmy answers it 400, harmlessly
|
||||
if (isNewPost && !string.IsNullOrEmpty(objectUri))
|
||||
{
|
||||
var boost = ActivityPubRenderer.Announce(group, objectUri, $"announce-object-{key}");
|
||||
await _delivery.EnqueueToFollowers(group, boost, token, authorsServer);
|
||||
await delivery.EnqueueToFollowers(group, boost, authorsServer, token);
|
||||
await Keep(group, boost, objectUri, token);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user