House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -20,20 +20,11 @@ namespace PrivaPub.Federation.Signing
|
||||
// a DM or a circle post refetches it, signed by the account it was for or by its instance actor, and Mastodon deletes its
|
||||
// copy when the refetch answers 404. So the post is served to a signed request from someone it was for, or from the
|
||||
// instance actor of a server where someone it was for lives; everyone else still gets 404.
|
||||
public class SignedFetchAuthorizer : ISignedFetchAuthorizer
|
||||
public class SignedFetchAuthorizer(
|
||||
IRemoteActorService remoteActors,
|
||||
DbEntities dbEntities,
|
||||
ILocalActorService localActors = default) : ISignedFetchAuthorizer
|
||||
{
|
||||
readonly IRemoteActorService _remoteActors;
|
||||
readonly DbEntities _dbEntities;
|
||||
|
||||
readonly ILocalActorService _localActors;
|
||||
|
||||
public SignedFetchAuthorizer(IRemoteActorService remoteActors, DbEntities dbEntities, ILocalActorService localActors = default)
|
||||
{
|
||||
_remoteActors = remoteActors;
|
||||
_dbEntities = dbEntities;
|
||||
_localActors = localActors;
|
||||
}
|
||||
|
||||
// the actor whose signature (draft-cavage, or RFC 9421 when there is a base address to check its target against)
|
||||
// verifies on the request
|
||||
public async Task<ForeignAvatar> Requester(HttpRequest request, CancellationToken token)
|
||||
@@ -41,11 +32,11 @@ namespace PrivaPub.Federation.Signing
|
||||
var signature = RequestSignature.Of(request);
|
||||
if (signature == default || signature.Problem(request, body: default) != default)
|
||||
return default;
|
||||
var signed = signature.Signed(request, _localActors?.BaseAddress ?? $"{request.Scheme}://{request.Host}");
|
||||
var actor = await _remoteActors.GetActorByKeyId(signature.KeyId, refresh: false, token);
|
||||
var signed = signature.Signed(request, localActors?.BaseAddress ?? $"{request.Scheme}://{request.Host}");
|
||||
var actor = await remoteActors.GetActorByKeyId(signature.KeyId, refresh: false, token);
|
||||
if (actor != default && signature.VerifiedBy(actor.PublicKey, signed))
|
||||
return actor;
|
||||
actor = await _remoteActors.GetActorByKeyId(signature.KeyId, refresh: true, token);
|
||||
actor = await remoteActors.GetActorByKeyId(signature.KeyId, refresh: true, token);
|
||||
return actor != default && signature.VerifiedBy(actor.PublicKey, signed) ? actor : default;
|
||||
}
|
||||
|
||||
@@ -58,14 +49,14 @@ namespace PrivaPub.Federation.Signing
|
||||
case PostVisibility.Public or PostVisibility.Unlisted:
|
||||
return true;
|
||||
case PostVisibility.Circle:
|
||||
var circle = string.IsNullOrEmpty(post.GroupId) ? default : await _dbEntities.Groups.MatchID(post.GroupId).ExecuteFirstAsync(token);
|
||||
var circle = string.IsNullOrEmpty(post.GroupId) ? default : await dbEntities.Groups.MatchID(post.GroupId).ExecuteFirstAsync(token);
|
||||
return circle != default && MayReadCircle(circle, requester);
|
||||
case PostVisibility.Direct:
|
||||
return Addressed(post).Any(uri => Is(requester, uri));
|
||||
case PostVisibility.FollowersOnly:
|
||||
if (Addressed(post).Any(uri => Is(requester, uri)))
|
||||
return true;
|
||||
var followers = await _dbEntities.Followers
|
||||
var followers = await dbEntities.Followers
|
||||
.Match(f => f.LocalActorId == post.GroupUserId && f.LocalActorKind == LocalActorKind.Person && f.IsAccepted)
|
||||
.ExecuteAsync(token);
|
||||
return followers.Any(f => Is(requester, f.ActorURI));
|
||||
|
||||
Reference in new issue
Block a user