House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -54,12 +54,13 @@ namespace PrivaPub.Infrastructure.Backup
|
||||
|
||||
public sealed class Held : IAsyncDisposable
|
||||
{
|
||||
readonly string _owner;
|
||||
readonly Timer _heartbeat;
|
||||
|
||||
string Owner { get; }
|
||||
|
||||
public Held(string owner)
|
||||
{
|
||||
_owner = owner;
|
||||
Owner = owner;
|
||||
_heartbeat = new Timer(_ => _ = DB.Default.Update<MaintenanceLock>().Match(l => l.ID == Name && l.Owner == owner)
|
||||
.Modify(l => l.Heartbeat, DateTime.UtcNow).ExecuteAsync(), default, Beat, Beat);
|
||||
}
|
||||
@@ -67,7 +68,7 @@ namespace PrivaPub.Infrastructure.Backup
|
||||
public async ValueTask DisposeAsync()
|
||||
{
|
||||
await _heartbeat.DisposeAsync();
|
||||
await DB.Default.Update<MaintenanceLock>().Match(l => l.ID == Name && l.Owner == _owner)
|
||||
await DB.Default.Update<MaintenanceLock>().Match(l => l.ID == Name && l.Owner == Owner)
|
||||
.Modify(l => l.Owner, null).Modify(l => l.Heartbeat, DateTime.MinValue).ExecuteAsync();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -101,7 +101,7 @@ namespace PrivaPub.Infrastructure.Backup
|
||||
file.Seek(offset, SeekOrigin.Begin);
|
||||
var buffer = new byte[81920];
|
||||
var total = 0L;
|
||||
int read;
|
||||
var read = default(int);
|
||||
while ((read = await piece.ReadAsync(buffer, token)) > 0)
|
||||
{
|
||||
total += read;
|
||||
|
||||
Reference in new issue
Block a user