House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s

- Services, controllers and jobs take their dependencies through primary
  constructors and use them directly; where a method already named a local
  after a dependency, the dependency takes its type's name.
- Every async method takes a CancellationToken last and passes it down to
  MongoDB, HTTP and the job queue. The setup claim is still given back when
  a request is cancelled.
- The federation and media options are read through IOptionsMonitor.
- The Mastodon entities keep sending "" for empty strings, and every model
  field where null means something says so.
- The inbox's 503 with Retry-After, which other servers retry, is the one
  server error left, and says why.
- Arasaka.HouseRules.Analyzers checks all of this in every build, here and in
  PrivaPub.ClientModels as decePubClient builds it.

Checked against GoToSocial in the pasture: 64 passed, 0 failed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
thepraandClaude Opus 5.5 committed 2026-11-10 01:24:43 +01:00
1 parent f0a14c737f
commit 0f73f69239
176 files changed
+2789 -3974

No files matched your search

@@ -43,17 +43,17 @@ namespace PrivaPub.Infrastructure.Data.Migrations
await DB.Default.SaveAsync(reservations);
}
static async Task DeleteAllBut<T>(IEnumerable<IOrderedEnumerable<T>> groups, Func<T, Task> delete)
static async Task DeleteAllBut<T>(IEnumerable<IOrderedEnumerable<T>> groups, Func<T, CancellationToken, Task> delete, CancellationToken token = default)
{
foreach (var group in groups)
foreach (var duplicate in group.Skip(1))
await delete(duplicate);
await delete(duplicate, token);
}
static Task DeleteForeignAvatar(ForeignAvatar a) => DB.Default.DeleteAsync<ForeignAvatar>(a.ID);
static Task DeletePost(Post p) => DB.Default.DeleteAsync<Post>(p.ID);
static Task DeleteDmPost(DmPost p) => DB.Default.DeleteAsync<DmPost>(p.ID);
static Task DeleteFollower(Follower f) => DB.Default.DeleteAsync<Follower>(f.ID);
static Task DeleteLink(RootToAvatar r) => DB.Default.DeleteAsync<RootToAvatar>(r.ID);
static Task DeleteForeignAvatar(ForeignAvatar a, CancellationToken token = default) => DB.Default.DeleteAsync<ForeignAvatar>(a.ID);
static Task DeletePost(Post p, CancellationToken token = default) => DB.Default.DeleteAsync<Post>(p.ID);
static Task DeleteDmPost(DmPost p, CancellationToken token = default) => DB.Default.DeleteAsync<DmPost>(p.ID);
static Task DeleteFollower(Follower f, CancellationToken token = default) => DB.Default.DeleteAsync<Follower>(f.ID);
static Task DeleteLink(RootToAvatar r, CancellationToken token = default) => DB.Default.DeleteAsync<RootToAvatar>(r.ID);
}
}
@@ -61,7 +61,7 @@ namespace PrivaPub.Infrastructure.Data.Migrations
static string Remote(string reference) =>
reference != default && reference.Contains("://") ? reference : default;
static async Task<string> ForeignAccountId(string actorUri) =>
(await DB.Default.Find<ForeignAvatar>().Match(a => a.ActorURI == actorUri).ExecuteFirstAsync())?.ID;
static async Task<string> ForeignAccountId(string actorUri, CancellationToken token = default) =>
(await DB.Default.Find<ForeignAvatar>().Match(a => a.ActorURI == actorUri).ExecuteFirstAsync(token))?.ID;
}
}