House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -13,17 +13,12 @@ namespace PrivaPub.Infrastructure.Jobs
|
||||
Task Failed(string host, string error, CancellationToken token);
|
||||
}
|
||||
|
||||
public class HostCircuitBreaker : IHostCircuitBreaker
|
||||
public class HostCircuitBreaker(
|
||||
IMemoryCache cache) : IHostCircuitBreaker
|
||||
{
|
||||
public const int Threshold = 10;
|
||||
static readonly TimeSpan CacheLifetime = TimeSpan.FromSeconds(30);
|
||||
|
||||
readonly IMemoryCache _cache;
|
||||
|
||||
public HostCircuitBreaker(IMemoryCache cache)
|
||||
{
|
||||
_cache = cache;
|
||||
}
|
||||
|
||||
public async Task<DateTime?> UnavailableUntil(string host, CancellationToken token)
|
||||
{
|
||||
@@ -43,7 +38,7 @@ namespace PrivaPub.Infrastructure.Jobs
|
||||
.Modify(i => i.LastSuccessAt, DateTime.UtcNow)
|
||||
.Option(o => o.IsUpsert = true)
|
||||
.ExecuteAsync(token);
|
||||
_cache.Remove(Key(host));
|
||||
cache.Remove(Key(host));
|
||||
}
|
||||
|
||||
public async Task Failed(string host, string error, CancellationToken token)
|
||||
@@ -61,11 +56,11 @@ namespace PrivaPub.Infrastructure.Jobs
|
||||
await DB.Default.Update<RemoteInstance>().MatchID(instance.ID)
|
||||
.Modify(i => i.UnavailableUntil, now + quarantine)
|
||||
.ExecuteAsync(token);
|
||||
_cache.Remove(Key(host));
|
||||
cache.Remove(Key(host));
|
||||
}
|
||||
|
||||
async Task<RemoteInstance> Instance(string host, CancellationToken token) =>
|
||||
await _cache.GetOrCreateAsync(Key(host), async entry =>
|
||||
await cache.GetOrCreateAsync(Key(host), async entry =>
|
||||
{
|
||||
entry.AbsoluteExpirationRelativeToNow = CacheLifetime;
|
||||
return await DB.Default.Find<RemoteInstance>().Match(i => i.Host == host).ExecuteFirstAsync(token);
|
||||
|
||||
Reference in new issue
Block a user