House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -3,25 +3,18 @@ using PrivaPub.StaticServices;
|
||||
|
||||
namespace PrivaPub.Services.ClientToServer.Public
|
||||
{
|
||||
public class DataService : IDataService
|
||||
public class DataService(
|
||||
DbEntities dbCollections,
|
||||
AppConfigurationService appConfigurationService) : IDataService
|
||||
{
|
||||
readonly DbEntities DbEntities;
|
||||
readonly AppConfigurationService AppConfigurationService;
|
||||
|
||||
public DataService(DbEntities dbCollections, AppConfigurationService appConfigurationService)
|
||||
{
|
||||
DbEntities = dbCollections;
|
||||
AppConfigurationService = appConfigurationService;
|
||||
}
|
||||
|
||||
// the build's ref (its tag, or the branch a manual deploy ran from), as /build.json and NodeInfo name it
|
||||
public string GetCurrentVersion() =>
|
||||
string.IsNullOrEmpty(BuildInfo.Ref) ? BuildInfo.Commit : BuildInfo.Ref;
|
||||
|
||||
public async Task<IEnumerable<Language>> GetLanguages(CancellationToken cancellationToken)
|
||||
{
|
||||
return (await DbEntities.Languages
|
||||
.Match(l => AppConfigurationService.AppConfiguration.SupportedLanguages.Contains(l.International2Code))
|
||||
return (await dbCollections.Languages
|
||||
.Match(l => appConfigurationService.AppConfiguration.SupportedLanguages.Contains(l.International2Code))
|
||||
.ExecuteAsync(cancellationToken)).OrderBy(l => l.NativeName).ToArray();
|
||||
}
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user