House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s

- Services, controllers and jobs take their dependencies through primary
  constructors and use them directly; where a method already named a local
  after a dependency, the dependency takes its type's name.
- Every async method takes a CancellationToken last and passes it down to
  MongoDB, HTTP and the job queue. The setup claim is still given back when
  a request is cancelled.
- The federation and media options are read through IOptionsMonitor.
- The Mastodon entities keep sending "" for empty strings, and every model
  field where null means something says so.
- The inbox's 503 with Retry-After, which other servers retry, is the one
  server error left, and says why.
- Arasaka.HouseRules.Analyzers checks all of this in every build, here and in
  PrivaPub.ClientModels as decePubClient builds it.

Checked against GoToSocial in the pasture: 64 passed, 0 failed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
thepraandClaude Opus 5.5 committed 2026-11-10 01:24:43 +01:00
1 parent f0a14c737f
commit 0f73f69239
176 files changed
+2789 -3974

No files matched your search

+20 -20
View File
@@ -7,44 +7,44 @@ namespace PrivaPub.Services
{
public interface IRootUsersService
{
Task<WebResult> LoginAsync(LoginForm loginForm);
Task<WebResult> LoginAsync(LoginForm loginForm, CancellationToken token = default);
Task<WebResult> SignUpAsync(LoginForm signUpForm);
Task<WebResult> SignUpAsync(LoginForm signUpForm, CancellationToken token = default);
Task<WebResult> BanUserAsync(UsersIds usersIds);
Task<WebResult> BanUserAsync(UsersIds usersIds, CancellationToken token = default);
Task<WebResult> UnbanUserAsync(UsersIds usersIds);
Task<WebResult> UnbanUserAsync(UsersIds usersIds, CancellationToken token = default);
Task<WebResult> RemoveUserAsync(UsersIds usersIds);
Task<WebResult> RemoveSelfAsync(string rootId, string password);
Task<WebResult> RemoveUserAsync(UsersIds usersIds, CancellationToken token = default);
Task<WebResult> RemoveSelfAsync(string rootId, string password, CancellationToken token = default);
/// <summary>Whether a login's password is this one, after the same hashing whatever the answer.</summary>
Task<bool> PasswordMatches(string rootId, string password);
Task<bool> PasswordMatches(string rootId, string password, CancellationToken token = default);
Task<WebResult> UpdateUserPasswordAsync(UserPasswordForm userPasswordForm, string userId);
Task<WebResult> UpdateUserPasswordAsync(UserPasswordForm userPasswordForm, string userId, CancellationToken token = default);
Task<WebResult> GetUserSettingsAsync(string userId, LoginForm loginForm = default);
Task<WebResult> GetUserSettingsAsync(string userId, LoginForm loginForm = default, CancellationToken token = default);
Task<WebResult> UpdateUserSettingsAsync(ViewUserSettings userSettings, string userId);
Task<WebResult> UpdateUserSettingsAsync(ViewUserSettings userSettings, string userId, CancellationToken token = default);
Task<WebResult> SetupAndSendRecoveryEmail(PasswordRecoveryForm passwordRecoveryForm, string host);
Task<WebResult> SetupAndSendRecoveryEmail(PasswordRecoveryForm passwordRecoveryForm, string host, CancellationToken token = default);
Task<WebResult> IsValidRecoveryCode(string recoveryCode);
Task<WebResult> IsValidRecoveryCode(string recoveryCode, CancellationToken token = default);
Task<WebResult> ChangePassword(NewPasswordForm newPasswordForm);
Task<WebResult> ChangePassword(NewPasswordForm newPasswordForm, CancellationToken token = default);
Task<WebResult> AccountAsync(string rootId);
Task<WebResult> AccountAsync(string rootId, CancellationToken token = default);
Task<WebResult> RequestEmailChangeAsync(string rootId, EmailChangeForm form);
Task<WebResult> RequestEmailChangeAsync(string rootId, EmailChangeForm form, CancellationToken token = default);
Task<WebResult> VerifyEmailAsync(string rootId, string code);
Task<WebResult> VerifyEmailAsync(string rootId, string code, CancellationToken token = default);
Task<WebResult> RemoveEmailAsync(string rootId, string password);
Task<WebResult> RemoveEmailAsync(string rootId, string password, CancellationToken token = default);
Task<WebResult> TotpSetupAsync(string rootId, string password);
Task<WebResult> TotpSetupAsync(string rootId, string password, CancellationToken token = default);
Task<WebResult> TotpEnableAsync(string rootId, string code);
Task<WebResult> TotpEnableAsync(string rootId, string code, CancellationToken token = default);
Task<WebResult> TotpDisableAsync(string rootId, string password, string code);
Task<WebResult> TotpDisableAsync(string rootId, string password, string code, CancellationToken token = default);
}
}