House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -16,22 +16,15 @@ namespace PrivaPub.Services
|
||||
|
||||
// The server's one way to send an email: through the SMTP account in appsettings (AppConfiguration:EmailConfiguration),
|
||||
// read as it is now. Only jobs call it, so nobody waits on SMTP.
|
||||
public class Mailer : IMailer
|
||||
public class Mailer(
|
||||
IOptionsMonitor<AppConfiguration> app,
|
||||
Domain.Instance.IInstanceSettings settings) : IMailer
|
||||
{
|
||||
readonly IOptionsMonitor<AppConfiguration> _app;
|
||||
readonly Domain.Instance.IInstanceSettings _settings;
|
||||
|
||||
public Mailer(IOptionsMonitor<AppConfiguration> app, Domain.Instance.IInstanceSettings settings)
|
||||
{
|
||||
_app = app;
|
||||
_settings = settings;
|
||||
}
|
||||
|
||||
public async Task Send(string to, string subject, string body, CancellationToken token)
|
||||
{
|
||||
var email = _app.CurrentValue.EmailConfiguration;
|
||||
var email = app.CurrentValue.EmailConfiguration;
|
||||
var message = new MimeMessage();
|
||||
message.From.Add(new MailboxAddress(_settings.Current.Title, email.SmtpUsername));//the server's name, as its administrator set it
|
||||
message.From.Add(new MailboxAddress(settings.Current.Title, email.SmtpUsername));//the server's name, as its administrator set it
|
||||
message.To.Add(MailboxAddress.Parse(to));
|
||||
message.Subject = subject;
|
||||
message.Body = new TextPart("plain") { Text = body };
|
||||
|
||||
Reference in new issue
Block a user