House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -6,24 +6,19 @@ using System.Globalization;
|
||||
|
||||
namespace PrivaPub.Services
|
||||
{
|
||||
public class RequestLocalizationOptionsService
|
||||
public class RequestLocalizationOptionsService(
|
||||
AppConfigurationService appConfigurationService)
|
||||
{
|
||||
RequestLocalizationOptions RequestLocalizationOptions { get; set; }
|
||||
readonly AppConfigurationService AppConfigurationService;
|
||||
|
||||
public RequestLocalizationOptionsService(AppConfigurationService appConfigurationService)
|
||||
{
|
||||
AppConfigurationService = appConfigurationService;
|
||||
}
|
||||
|
||||
public async Task<RequestLocalizationOptions> Get()
|
||||
public async Task<RequestLocalizationOptions> Get(CancellationToken token = default)
|
||||
{
|
||||
if (RequestLocalizationOptions != default) return RequestLocalizationOptions;
|
||||
if (AppConfigurationService.AppConfiguration == default)
|
||||
await AppConfigurationService.Init();
|
||||
if (appConfigurationService.AppConfiguration == default)
|
||||
await appConfigurationService.Init(token);
|
||||
|
||||
RequestLocalizationOptions = new RequestLocalizationOptions();
|
||||
var cultures = AppConfigurationService
|
||||
var cultures = appConfigurationService
|
||||
.AppConfiguration
|
||||
.SupportedLanguages
|
||||
.Select(sl => new CultureInfo(sl))
|
||||
|
||||
Reference in new issue
Block a user