House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s

- Services, controllers and jobs take their dependencies through primary
  constructors and use them directly; where a method already named a local
  after a dependency, the dependency takes its type's name.
- Every async method takes a CancellationToken last and passes it down to
  MongoDB, HTTP and the job queue. The setup claim is still given back when
  a request is cancelled.
- The federation and media options are read through IOptionsMonitor.
- The Mastodon entities keep sending "" for empty strings, and every model
  field where null means something says so.
- The inbox's 503 with Retry-After, which other servers retry, is the one
  server error left, and says why.
- Arasaka.HouseRules.Analyzers checks all of this in every build, here and in
  PrivaPub.ClientModels as decePubClient builds it.

Checked against GoToSocial in the pasture: 64 passed, 0 failed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
thepraandClaude Opus 5.5 committed 2026-11-10 01:24:43 +01:00
1 parent f0a14c737f
commit 0f73f69239
176 files changed
+2789 -3974

No files matched your search

+10 -19
View File
@@ -18,21 +18,12 @@ namespace PrivaPub.Services
// and the Mastodon API tokens and authorizations of each of its personas, with their Web Push subscriptions. Used when its password is changed or
// recovered, when it signs out everywhere and when it is deleted. End signs out one session only: the device that
// asked (its Mastodon tokens it revokes itself).
public class RootSessions : IRootSessions
public class RootSessions(
DbEntities dbEntities,
IOpenIddictTokenManager openIddictTokenManager,
IOpenIddictAuthorizationManager authorizations,
AuthTokenManager authTokens) : IRootSessions
{
readonly DbEntities _dbEntities;
readonly IOpenIddictTokenManager _tokens;
readonly IOpenIddictAuthorizationManager _authorizations;
readonly AuthTokenManager _authTokens;
public RootSessions(DbEntities dbEntities, IOpenIddictTokenManager tokens, IOpenIddictAuthorizationManager authorizations, AuthTokenManager authTokens)
{
_dbEntities = dbEntities;
_tokens = tokens;
_authorizations = authorizations;
_authTokens = authTokens;
}
public async Task Revoke(string rootId, CancellationToken token)
{
await DB.Default.Update<RootUser>().MatchID(rootId)
@@ -40,14 +31,14 @@ namespace PrivaPub.Services
.Modify(u => u.SessionStamp, Guid.NewGuid().ToString("N"))
.Modify(u => u.EndedSessions, new List<EndedSession>())//the new stamp ends those too
.ExecuteAsync(token);
var links = await _dbEntities.RootToAvatars.Match(ra => ra.RootId == rootId).ExecuteAsync(token);
var links = await dbEntities.RootToAvatars.Match(ra => ra.RootId == rootId).ExecuteAsync(token);
foreach (var link in links)
{
await _tokens.RevokeBySubjectAsync(link.AvatarId, token);
await _authorizations.RevokeBySubjectAsync(link.AvatarId, token);
await openIddictTokenManager.RevokeBySubjectAsync(link.AvatarId, token);
await authorizations.RevokeBySubjectAsync(link.AvatarId, token);
}
// their Web Push subscriptions go with their tokens (R9)
await Domain.Social.WebPush.Forget(links.Select(l => l.AvatarId).ToList());
await Domain.Social.WebPush.Forget(links.Select(l => l.AvatarId).ToList(), token);
}
// remembered as long as one of its tokens could still be valid; the ones that have expired are forgotten meanwhile
@@ -58,7 +49,7 @@ namespace PrivaPub.Services
.Modify(b => b.PullFilter(u => u.EndedSessions, s => s.Until < now))
.ExecuteAsync(token);
await DB.Default.Update<RootUser>().MatchID(rootId)
.Modify(b => b.Push(u => u.EndedSessions, new EndedSession { Sid = sessionId, Until = now + _authTokens.Lifetime }))
.Modify(b => b.Push(u => u.EndedSessions, new EndedSession { Sid = sessionId, Until = now + authTokens.Lifetime }))
.ExecuteAsync(token);
}
}