House rules: primary constructors, a cancellation token on every async call, and the rules fail the build
Build / Build (push) Successful in 30s
Build / Build (push) Successful in 30s
- Services, controllers and jobs take their dependencies through primary constructors and use them directly; where a method already named a local after a dependency, the dependency takes its type's name. - Every async method takes a CancellationToken last and passes it down to MongoDB, HTTP and the job queue. The setup claim is still given back when a request is cancelled. - The federation and media options are read through IOptionsMonitor. - The Mastodon entities keep sending "" for empty strings, and every model field where null means something says so. - The inbox's 503 with Retry-After, which other servers retry, is the one server error left, and says why. - Arasaka.HouseRules.Analyzers checks all of this in every build, here and in PrivaPub.ClientModels as decePubClient builds it. Checked against GoToSocial in the pasture: 64 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4YtEJrgxG12Pc39Fai8Bd
This commit is contained in:
1 parent
f0a14c737f
commit
0f73f69239
176 files changed
+2789
-3974
No files matched your search
@@ -10,7 +10,8 @@ using System.Text;
|
||||
|
||||
namespace PrivaPub.StaticServices
|
||||
{
|
||||
public class AuthTokenManager
|
||||
public class AuthTokenManager(
|
||||
IConfiguration configuration)
|
||||
{
|
||||
public const string SessionStamp = "ss";
|
||||
const string SessionStampClaim = SessionStamp;//the root's RootUser.SessionStamp when issued; JwtEvents refuses a stale one
|
||||
@@ -18,20 +19,14 @@ namespace PrivaPub.StaticServices
|
||||
// (RootUser.EndedSessions). Not "sid", which JwtBearer maps to another claim type on the way in.
|
||||
public const string SessionId = "si";
|
||||
|
||||
readonly IConfiguration Configuration;
|
||||
|
||||
public AuthTokenManager(IConfiguration configuration)
|
||||
{
|
||||
Configuration = configuration;
|
||||
}
|
||||
|
||||
public TimeSpan Lifetime => TimeSpan.FromHours(int.Parse(Configuration["AppConfiguration:Jwt:HoursTimeout"]));
|
||||
public TimeSpan Lifetime => TimeSpan.FromHours(int.Parse(configuration["AppConfiguration:Jwt:HoursTimeout"]));
|
||||
|
||||
/// <summary>A token for the root; a renewal passes the session it renews, a new sign-in gets a new one.</summary>
|
||||
public JwtUser GenerateToken(RootUser user, ViewUserSettings userSettings, string sessionId = default)
|
||||
{
|
||||
var expiration = DateTime.UtcNow + Lifetime;
|
||||
var securityKey = new SymmetricSecurityKey(Encoding.UTF8.GetBytes(Configuration["AppConfiguration:Jwt:Key"]));
|
||||
var securityKey = new SymmetricSecurityKey(Encoding.UTF8.GetBytes(configuration["AppConfiguration:Jwt:Key"]));
|
||||
var jwtUser = new JwtUser
|
||||
{
|
||||
UserId = user.ID,
|
||||
@@ -53,7 +48,7 @@ namespace PrivaPub.StaticServices
|
||||
claims.Add(new(Policies.IsModerator, $"{user.Policies.Contains(Policies.IsModerator)}".ToLower()));
|
||||
claims.Add(new(Policies.IsAdmin, $"{user.Policies.Contains(Policies.IsAdmin)}".ToLower()));
|
||||
|
||||
var token = new JwtSecurityToken(issuer: Configuration["AppConfiguration:Jwt:Issuer"], audience: Configuration["AppConfiguration:Jwt:Audience"],
|
||||
var token = new JwtSecurityToken(issuer: configuration["AppConfiguration:Jwt:Issuer"], audience: configuration["AppConfiguration:Jwt:Audience"],
|
||||
claims: claims,
|
||||
notBefore: DateTime.UtcNow,
|
||||
expires: expiration,
|
||||
|
||||
Reference in new issue
Block a user